corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 344 forks source link

Duplicate "." at the end of a sentence #803

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

There are two "." at the end of these strings:

https://github.com/corona-warn-app/cwa-app-ios/blob/d22b0e4512f41d8eea27ffd90c109ba6564eb2c3/src/xcode/ENA/ENA/Resources/Localization/en.lproj/Localizable.strings#L119

https://github.com/corona-warn-app/cwa-app-android/blob/a1110d3d0906273936ef1db7e8024ec581f8dfbc/Corona-Warn-App/src/main/res/values/strings.xml#L261

Steps to reproduce the issue

Should be clear. Read the text.

Expected behaviour

Only one ".".

Possible Fix

Remove one ".".

Pings

FYI @marcussc, @mtwalli, @matthiasdiener & @krichly


Internal Tracking ID: EXPOSUREAPP-11251

larswmh commented 2 years ago

Thanks for your report @Ein-Tim. Internal Tracking ID: EXPOSUREAPP-11251


Corona-Warn-App Open Source Team

Ein-Tim commented 2 years ago

Fixed with https://github.com/corona-warn-app/cwa-app-android/commit/1634e94b53af8ad3fa7cfc7e1ee123ca02d66bf4 for Android.

Fixed with https://github.com/corona-warn-app/cwa-app-ios/commit/571bcb9682c15412729b3effe4054168c05ab326 for iOS.

@larswmh Feel free to add the Fix 2.16 label to this issue.

MikeMcC399 commented 2 years ago

@Ein-Tim

The fix may be on its way, but it hasn't reached the release/2.16.x branch yet. See

https://github.com/corona-warn-app/cwa-app-android/blob/release/2.16.x/Corona-Warn-App/src/main/res/values/strings.xml#L258-L259

<!-- XMSG: risk details - go/stay home, something like a bullet point -->
<string name="risk_details_behavior_body_stay_home">"If possible, please go home and stay at home and avoid any encounters outside of your own household.."</string>

Perhaps check again later today or tomorrow?

Ein-Tim commented 2 years ago

@MikeMcC399

The fix was just merged:

Ein-Tim commented 2 years ago

Closing this issue now, as it was fixed in version 2.16.