search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 344 forks source link

Add a log entry with new cwa version info after a cwa update #811

Closed ndegendogo closed 2 years ago

ndegendogo commented 2 years ago

Avoid duplicates

Current Implementation

The current error log starts with the configuration, like cwa version number, iOS version, device type. This is very helpful. However, the logging can be active during cwa updating to a newer version. And in this case the new version number is not logged, which can be confusing or misleading.

Suggested Enhancement

In case of cwa updating to a new version, add a log entry with the new version info. Ideally in a similar format like the original entry, so it will be easy to find.

Expected Benefits

Less confusion and clearer info when reading / analysing a long error log.

Note: I don't know the current Android implementation; but can imagine that this idea is also applicable for Android. If this is true, feel free to move the ticket accordingly.

Internal Tracking ID: EXPOSUREAPP-11560

larswmh commented 2 years ago

Thanks for your report @ndegendogo. I have moved this issue to another repository, as this is applicable to both Android and iOS. We have created an internal ticket for it and will raise this topic internally. Internal Tracking ID: EXPOSUREAPP-11560

Corona-Warn-App Open Source Team

Ein-Tim commented 2 years ago

Is there any update on this 3 months old issue available?

ndegendogo commented 2 years ago

For iOS it is resolved! In my log file I see entries like the following (indicating an update from v2.19.1 to v2.20):

932932 Debug 2022-04-04T06:16:35Z 932933 [ENA/HomeTableViewController.swift:737] [showDeltaOnboardingIfNeeded(completion:)] 932934 Start onboarding. 932935 932936 Debug 2022-04-04T06:16:35Z 932937 [ENA/DeltaOnboardingProtocols.swift:23] [isFinished] 932938 Check, if 2.20ENA.DeltaOnboardingNewVersionFeatures is already finished or not needed (current onboarding version = 2.19.1... 932939 932940 Debug 2022-04-04T06:16:35Z 932941 [ENA/DeltaOnboardingProtocols.swift:26] [isFinished] 932942 DeltaOnboarding 2.20ENA.DeltaOnboardingNewVersionFeatures already presented? false.

For Android I cannot tell...

Ein-Tim commented 2 years ago

I will check when 2.21 under Android is released.

Ein-Tim commented 2 years ago

I just received 2.21 but somehow the app stopped logging after the update. Maybe @MikeMcC399 could cross check here:

  1. Start logging on version 2.20
  2. Update to version 2.21
  3. Let us know if the log still runs after the update
MikeMcC399 commented 2 years ago

@Ein-Tim

I checked for the CWA Android update from version 2.19.2 to 2.20.3

Running CWA 2.19 shows I/CWADebug: CWA version: 2190201 (no commit hash) Updating to CWA 2.20 I/CWADebug: CWA version: 2200300 (no commit hash)

If in your case the app stopped logging, that would be a separate issue. I expect it will be another 48 hours or so before I have access to the released 2.21 Android version.

MikeMcC399 commented 2 years ago

@ndegendogo

I think this issue can be closed. Thanks for opening this issue. It was a good request / suggestion!

Ein-Tim commented 2 years ago

Thanks @MikeMcC399!

ndegendogo commented 2 years ago

Closing as fixed.

dsarkar commented 2 years ago

@ndegendogo @MikeMcC399 @Ein-Tim thanks for the feedback. CONFIRM forwarded to internal ticket.