search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 345 forks source link

[Android] "3 of 1" certificate not used in a series of "1 of 1", "2 of 2" and "3 of 1" #842

Closed smares closed 2 years ago

smares commented 2 years ago

My mom just received her 3rd vaccine after being vaccinated with Janssen (displayed as "1 of 1") and Comirnaty (displayed as "2 of 2"). The 3rd vaccination certificate was created as being "3 of 1". CWA keeps using the 2nd certificate and the icon that appears next to the third certificate is a shield filled with 50%. Is this a bug in the app or is the certificate faulty?

Internal Tracking ID: EXPOSUREAPP-11634

thomasaugsten commented 2 years ago

I assume the vaccination date of the 3 of 1 was in less than 14 days? This display issue will be fixed in the next version. This version will be release tomorrow or on Saturday.

Ein-Tim commented 2 years ago

@thomasaugsten

Was this fixed in version 2.17.2 under Android?

dsarkar commented 2 years ago

@Ein-Tim I think yes: https://github.com/corona-warn-app/cwa-app-android/pull/4764

Ein-Tim commented 2 years ago

@dsarkar This PR only talks about the 2/1 case so I'm not certain.

dsarkar commented 2 years ago

@Ein-Tim ok, I will check.

vaubaehn commented 2 years ago

The line of interest in the case here is https://github.com/corona-warn-app/cwa-app-android/blob/7dac081eda90ad586103f79f63091546a2a3f17f/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/vaccination/core/VaccinatedPerson.kt#L100

So I'd assume that should be fixed (3/1), but still detect 2/1 as a booster for all combinations of immunizations, which is wrong according to a variety of German legislation.

thomasaugsten commented 2 years ago

This is fixed in 2.17.2 and also the detection of 2/1 as booster is intended.

dsarkar commented 2 years ago

@smares Could you check with latest version 2.17.2. Thanks for your feedback!

Best wishes, DS

Corona-Warn-App Open Source Team

smares commented 2 years ago

Works as intended now. 😄

dsarkar commented 2 years ago

@smares Thanks for the feedback!

Best wishes, DS

Corona-Warn-App Open Source Team