corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 345 forks source link

Certificate grouping implementation differs between iOS & Android #869

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

The certificate grouping feature has a different implementation under iOS & Android. While iOS does not show the second name, Android does.

Steps to reproduce the issue

  1. Add a certificate with only only fore- & surname
  2. Add another certificate for the same person with forename, middle name & surname
  3. See that under iOS only fore- & surname are shown
  4. See that under Android fore-, middle & surname are shown

Expected behaviour

The implementation should not differ between iOS and Android

Possible Fix

Align iOS to Android.

Additional context

I can provide certificates via Mail if wished.


Internal Tracking ID: EXPOSUREAPP-12300

dsarkar commented 2 years ago

@Ein-Tim Thanks for reporting

dsarkar commented 2 years ago

Internal Tracking ID: EXPOSUREAPP-12300

mlenkeit commented 2 years ago

@Ein-Tim do I understand this report correctly, that the grouping itself works consistently across iOS and Android, but that only the name that is displayed for the "group" differs?

Ein-Tim commented 2 years ago

@mlenkeit

Yes, this is what I am experiencing.

mlenkeit commented 2 years ago

Ok, understood. This behavior is indeed not clearly defined, we'll take a look at it.

Ein-Tim commented 2 years ago

Update:

To fix this I suggest to align iOS to Android because then the implementation is constant between iOS/Android CWA & iOS/Android CovPass.

svengabr commented 2 years ago

I have just checked the linked Jira issue.

Jira Ticket is flagged as: Resolution: Wont Fix Status: Obsolete

Developer comment:

As there is no way to decide whats wrong or right, we decided to keep the current behaviour for both OS

Ein-Tim commented 2 years ago

@svengabr

We just saw an issue getting closed today for feature parity reasons, here feature parity seems to be not important. Maybe it's worth outlining when the team thinks implementation may differ and when not...