search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 344 forks source link

Conflicting advice for non-current vaccination certificate renewal #899

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Technical details

This issue also affects iOS.

Describe the bug

When a vaccination certificate has a Technical Expiration Date in the zone for renewal (28 days before expiry) the following texts are displayed:

The second sentence providing advice is contradictory to the first statement. In the case of no action is required, then the user should not be instructed to get a new certificate.

Steps to reproduce the issue

In CWA Android:

  1. Tap Scan button and scan a 1/2 vaccination certificate which expires in the next 28 days
  2. Tap back arrow
  3. Tap scan button and scan a 2/2 vaccination certificate (with expiry date more than 28 days into the future)
  4. Tap back arrow
  5. Tap Certificates
  6. Tap right arrow
  7. Scroll down to Vaccination 2 of 2 and note that it is marked as "Currently used certificate"
  8. Scroll down to Vaccination 1 of 2 and tap on tile
  9. Read the text underneath the QR code which includes the sentence "If this is not the certificate you currently use, it does not have to be extended and no action is required on your part."
  10. Scroll further down the page and note the text "Please make sure to get a new digital certificate in time."

Expiry less than 28 days

Expected behavior

The app should not advise "Please make sure to get a new digital certificate in time" for a vaccination certificate which is not marked as "Currently used certificate".

Possible Fix

Suppress the layout "Technical Expiration Date" with the text "Please make sure to get a new digital certificate in time." if a vaccination certificate is not the latest in a series of vaccinations.

Internal Tracking ID: EXPOSUREAPP-13343 Android Internal Tracking ID: EXPOSUREAPP-13403 iOS

MikeMcC399 commented 2 years ago
MikeMcC399 commented 2 years ago
mlenkeit commented 2 years ago

@MikeMcC399 thanks for bringing this up. We indeed missed that text when we made the adjustments. The PR that you referenced should fix it.

MikeMcC399 commented 2 years ago

Fixed in v2.24.0-rc.2.

The text "Please make sure to get a new digital certificate in time." has been generally removed under the heading "Technical Expiration Date".

The text is no longer necessary because the app gives explicit instructions if a renewal is recommended.

Ein-Tim commented 2 years ago

@mlenkeit I did not find a PR for iOS, this is also an issue under iOS. Will you fix it there too?

Ein-Tim commented 2 years ago

Recommendation to move this to the documentation repo as it affects both, iOS & Android.

MikeMcC399 commented 2 years ago

@Ein-Tim

Since this is already fixed in Android, I suggest to open a new iOS issue, rather than move this issue to documentation. It will have a separate internal ID anyway for iOS.

mlenkeit commented 2 years ago

@mlenkeit I did not find a PR for iOS, this is also an issue under iOS. Will you fix it there too?

Yes, it will be adjusted for iOS as well.

Ein-Tim commented 2 years ago

iOS PR: https://github.com/corona-warn-app/cwa-app-ios/pull/4628

larswmh commented 2 years ago

Closing this issue as it was fixed with yesterday's update to version 2.24 on both operating systems.

MikeMcC399 commented 2 years ago

@larswmh

Closing this issue as it was fixed with yesterday's update to version 2.24 on both operating systems.

Were you able to check with the CWA 2.24 Android version from the Google Play Store? I have not received this yet, which is the reason that I had not closed the issue so far.

Edit: Checked with CWA 2.24 Android release version. The issue is resolved.