search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.29k stars 345 forks source link

Conflicting information on certificate renewal limit in app #900

Closed Ein-Tim closed 1 year ago

Ein-Tim commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

In the app there is conflicting information on the limit how often a certificate can be renewed.

Here in the info text it says only once:

But then, if there is an error due to the rate limit, it says 3 times:

Steps to reproduce the issue

  1. Start the renewal process for a certificate which has already been renewed more than 3 times
  2. See the information text
  3. Click on "Einverstanden"
  4. See the error text which conflicts the information text

Expected behaviour

First it needs to be clarified if one renewal is the limit or if it's possible to renew one certificate up to 3 times.

Possible Fix

Change the text.

Internal Tracking ID: EXPOSUREAPP-13423

MikeMcC399 commented 2 years ago

@Ein-Tim

Bug is not already reported in another issue - I remember that somewhere, I think it was @MikeMcC399, mentioned this already

I have not reported this inconsistency anywhere else.

MikeMcC399 commented 2 years ago

@Ein-Tim

MikeMcC399 commented 2 years ago

@Ein-Tim

First it needs to be clarified if one renewal is the limit or if it's possible to renew one certificate up to 3 times.

The blog is clear about this point:

"A technically expired certificate can only be renewed three times. If users have stored their certificates in the CWA on several devices, they can only renew it on three of them. However, they have the option to export the newly issued certificate as a PDF file so that they can re-scan the QR code of the certificate if needed. "

dsarkar commented 2 years ago

Good morning @MikeMcC399 @Ein-Tim!

Thanks for reporting, Internal Tracking ID: EXPOSUREAPP-13423.

Best wishes, DS

Corona-Warn-App Open Source Team

Ein-Tim commented 2 years ago

@MikeMcC399

Thanks for clarifying & opening the other issue.

@dsarkar Thank you!

Ein-Tim commented 2 years ago

@dsarkar

I'd be happy to provide a PR for this under iOS. Let me know if this would be appreciated.

~Suggested text:~

~"Um sicherzustellen, dass Zertifikate nicht öfter als drei mal erneuert werden können, werden jeweils die Kennung des alten und des erneuerten Zertifikats durch das RKI dokumentiert."~

Ein-Tim commented 2 years ago

New suggestion based on the text in https://github.com/Digitaler-Impfnachweis/covpass-apps-i18n/pull/221:

"Um sicherzustellen, dass Zertifikate nur in begrenztem Umfang aktualisiert werden können, wird die Kennung des alten Zertifikats durch das RKI dokumentiert."

Ein-Tim commented 2 years ago

PR Android: https://github.com/corona-warn-app/cwa-app-android/pull/5308 PR iOS: https://github.com/corona-warn-app/cwa-app-ios/pull/4643

MikeMcC399 commented 2 years ago

@Ein-Tim

So it seems this will be fixed in version 2.25 (which needs new label creating).

Ein-Tim commented 1 year ago

This issue has been fixed in version 2.25. I can confirm the fix. Closing.