search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.29k stars 345 forks source link

Text issue: "verlängert" instead of "erneuert" #907

Closed Ein-Tim closed 1 year ago

Ein-Tim commented 1 year ago

Avoid duplicates

Technical details

Describe the bug

The apps use "verlängert" instead of "erneuert" at the following places:

https://github.com/corona-warn-app/cwa-app-ios/blob/c009baf4456dd7d03ad0957eac372be392889e70/src/xcode/ENA/ENA/Resources/Localization/de.lproj/Localizable.strings#L3368

https://github.com/corona-warn-app/cwa-app-android/blob/8dbb893ba28c899c860d10653d0f1cf1bccba0aa/Corona-Warn-App/src/main/res/values-de/covid_certificate_strings.xml#L267

Steps to reproduce the issue

  1. Open the CWA
  2. Click on "Certificates"
  3. Click on a person with a soon expiring / already expired certificate
  4. Click on the certificate which is about to expire or already expired
  5. Read the text

Expected behaviour

The app uses "erneuert" everywhere else, so I would expect to also have the word "erneuert" and not "verlängert" in this text.

Possible Fix

Change the text from

"Sollte dies nicht eines Ihrer aktuell verwendeten Zertifikate sein, muss es nicht verlängert werden und Sie müssen nichts weiter tun."

to

"Sollte dies nicht eines Ihrer aktuell verwendeten Zertifikate sein, muss es nicht erneuert werden und Sie müssen nichts weiter tun."

dsarkar commented 1 year ago

@Ein-Tim Thanks for reporting!

mlenkeit commented 1 year ago

The word extend should be used in case of soon expiring certificates, whereas renew should be used for certificates that were issued as 2/2 instead of 2/1.

MikeMcC399 commented 1 year ago

@mlenkeit

The dictionary https://dictionary.cambridge.org/dictionary/english/renew uses the word renew in a similar way to the case of expiring certificates, for example:

A new season ticket would be identical to the previous season, except with a new date (and maybe a new price). A passport would also be essentially identical to the previous passport, although there would usually be a new photo used.

You may be locked into the terms used and no longer have any flexibility, but if there is still free choice, I would use renew for expiring certificates and replace for the case of vaccination certificates which are converted to a different numbering scheme.

MikeMcC399 commented 1 year ago

@Ein-Tim

For Android you have referred to the following string which uses "renew" in most places, but then, in the last sentence, it uses the term "extended":

<string name="expiration_info">"If this is one of the certificates you currently use, please be sure to renew it on time. You can renew such certificates directly in the app if they will expire within the next 28 days or expired within the last 90 days, provided they were issued in Germany. In this case, the “Renew Certificates” option appears in your certificate overview, below the “Proof of Status” tile. If this is not one of the certificates you currently use, it does not have to be extended and no action is required on your part."</string>

If I understood you correctly, you are just asking for the word "extended" in the last sentence to be changed to "renewed" for consistency with the rest of the text.

Is that correct?

In the equivalent German text, there are also two terms used: "erneuern" and "verlängern". So I suggest that this text is also reviewed for consistency, since this is less of a translation issue if the base German text also uses different terms.

<string name="expiration_info">Wenn dies eines Ihrer aktuell verwendeten Zertifikate ist, bemühen Sie sich bitte rechtzeitig darum, es zu erneuern. Im Zeitraum von 28 Tagen vor und bis zu 90 Tagen nach Ablauf können Sie es direkt über die App erneuern lassen, sofern es in Deutschland ausgestellt wurde. Sie finden die Option \"Zertifikate erneuern\" dann in Ihrer Zertifikatsübersicht unter der Kachel \"Status-Nachweis\". Sollte dies nicht eines Ihrer aktuell verwendeten Zertifikate sein, muss es nicht verlängert werden und Sie müssen nichts weiter tun.</string>

Ein-Tim commented 1 year ago

@mlenkeit

Mh, I have a 2/2 expired certificate in the app and I have the option to "Renew Certificates". This is not the term I'd expect following your definition.

MikeMcC399 commented 1 year ago

@Ein-Tim

As far as I can see, the CWA Android 2.25.0 app uses the term "renew" consistently everywhere, except in that one place where it refers to "extended" at the very end of the paragraph.

Ein-Tim commented 1 year ago

@MikeMcC399

Yep, that's why I reported this issue. Thanks also for checking the German translation!

MikeMcC399 commented 1 year ago

I suggest for an Android and iOS PR to change the sentence:

"Sollte dies nicht eines Ihrer aktuell verwendeten Zertifikate sein, muss es nicht verlängert werden und Sie müssen nichts weiter tun."

to

"Sollte dies nicht eines Ihrer aktuell verwendeten Zertifikate sein, muss es nicht erneuert werden und Sie müssen nichts weiter tun."

(verlängert => erneuert)

The text should be consistently based on the verb "erneuern" (see screenshot below).

The translation process should take care of the rest, including correcting the English text.

image

MikeMcC399 commented 1 year ago

@Ein-Tim

You might like to consider changing the title of this issue, since it is not a translation error. The original German text uses the word "verlängert" which has been correctly translated into "extended".

Ein-Tim commented 1 year ago

@MikeMcC399

I will adapt both the title as well as the OP of the issue later.

@mlenkeit What's your take now? Will this issue be fixed?

Ein-Tim commented 1 year ago

As the CWA project went into ramp-down mode, I don't expect this text issue to be fixed anymore. I'm therefore closing this issue.