corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.29k stars 345 forks source link

my certificate does not validate for France #932

Closed ndegendogo closed 1 year ago

ndegendogo commented 1 year ago

Avoid duplicates

Technical details

Describe the bug

Today I got my 4th vaccination together with my certificate. The certificate states the product as "Comirnaty", and the manufacturer as "Biontech". See image. But when I check its validity for France, the check fails with the error message: "Only vaccines in the allowed valueset that have been approved by the French Authority (Pfizer, Moderna, Astra Zeneca, Janssen, Novavax, Covishield, R-covi, Covid 19 Vaccine and some clinical trials)."

Steps to reproduce the issue

Possible Fix

Additional context


Internal Tracking ID: EXPOSUREAPP-14307

ndegendogo commented 1 year ago

1953E7DB-32E1-4C59-A2F4-C79FBD27E9EA

ndegendogo commented 1 year ago

3696E5D2-6F95-4A9E-98A7-B508B56D9BD2

larswmh commented 1 year ago

Thanks for your report @ndegendogo. We have created an internal ticket for it and will raise this topic internally. Internal Tracking ID: EXPOSUREAPP-14307


Corona-Warn-App Open Source Team

Ein-Tim commented 1 year ago

@ndegendogo & @larswmh All the CWA team can do in such cases is to relay this information to the team of the respective country. The CWA team itself doesn't have any influence on the rules of other countries.

There are multiple countries with out of date / erroneous / wrong rules.

ndegendogo commented 1 year ago

@Ein-Tim

I agree that currently nobody looks at the certificate (and hopefully the pandemy 🦠 will never again raise to such a level that this is needed! πŸ‘Ή) - but what is the worth of an European certificate if it is not accepted / well understood in all participating countries? 🀷

Ein-Tim commented 1 year ago

@ndegendogo

Sorry if my comment sounded like I think this issue is not suitable here! I actually think it's good that you reported it. I noticed many problems with the rules check & some Twitter users actually told me where the check is wrong, however, I never reported these issues in the last months, as it didn't seem related to the CWA itself. But your issue is perfectly fine to stay here, although it should be moved to the documentation repo (@larswmh, could you do that please).

I will open a new issue in the documentation repo asking whether there is some sort of QA process reg. the travel validity check or similar.


cwa team can cross-check if the app is indeed using the latest policy rules from France (are these rules hard-coded? or dynamically loaded from a server? and does the server ensure to have the latest rules?)

FYI: You can cross-check yourself here: https://timokoenig.github.io/eu-dcc-rules/?ruleset=eu-dcc-rules&country=FR&rule=GR-FR-0000

ndegendogo commented 1 year ago

Thanks @Ein-Tim πŸ‘

I had a look at your given link; and the whole topic of these country-specific business rules on the certificates seems quite complex πŸ˜΅β€πŸ’«(and, tbh, a bit confusing πŸ˜…)

MikeMcC399 commented 1 year ago

The app checks are out of sync with the regulations.

https://reopen.europa.eu/en/map/FRA/7001 says:

image

thomasaugsten commented 1 year ago

France is using an external variable which is only available in the france app. We will inform France about the issue.

MikeMcC399 commented 1 year ago

If France no longer has any rules to apply (see https://reopen.europa.eu/en/map/FRA/7001), then the French rules used in the app should be replaced by something like the Swiss rule:

https://timokoenig.github.io/eu-dcc-rules/?ruleset=eu-dcc-rules&country=CH&rule=GR-CH-0002

"EU/EFTA citizens and their family members, irrespective of their nationality, have rights of free movement. Entry to the country is currently possible without pandemic-related measures."

thomasaugsten commented 1 year ago

We also give this information to the French colleagues.

thomasaugsten commented 1 year ago

France is already investigating this and has still the possibility to this checks depending on the visited countries of the user.

ndegendogo commented 1 year ago

Wow - thanks for investigating and taking action! πŸ‘πŸ‘

ndegendogo commented 1 year ago

Can you tell / find out if France plans to make these missing "external variables" available to cwa in future?

Alternatively I would suggest that cwa policy rule engine should check for such missing external variables, and in that case regard the rules as "incomplete" - check not possible (like is currently done if no rule is available for a country, like Portugal).

MikeMcC399 commented 1 year ago
larswmh commented 1 year ago

Thanks for your feedback. We have some news regarding this issue. Business Rules are provided by the issuing country and not something we can fix in the CWA. As soon as the country provides the missing business rules, they will also fix the behavior in the app.

thomasaugsten commented 1 year ago

Problem from France side should be fixed

ndegendogo commented 1 year ago

Tested - ok! Closing the ticket.

Thanks @thomasaugsten