search

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.29k stars 345 forks source link

Linked TCN Coalition website shows now gambling/online casino? content #944

Closed eliasp closed 1 year ago

eliasp commented 1 year ago

Where to find the issue

The "About this Project" section of README.md .

Describe the issue

The link to the URL https://tcn-coalition.org/ is not valid anymore, as this website just redirects via a 301 to the URL https://www.longshipbrewery.com/ which again has some kind of spammy gambling/online casino content or so.

Suggested change

Find out whether the TCN Coalition's website changed - if so, update the URL. If this website just isn't no more, drop the link or point to the last proper version provided by archive.org's Wayback Machine.

MikeMcC399 commented 1 year ago

@eliasp

Thanks for spotting this link issue! Although the links are checked that they are still working, they are not checked for content, so the automatic checks didn't notice the issue!

I will submit a PR to change the link to point to the https://github.com/TCNCoalition/TCN site which contains useful information. The GitHub site also in turn links to the https://www.longshipbrewery.com/ page, however by linking in the GitHub site as much historical information as possible would still be preserved.

MikeMcC399 commented 1 year ago
brianebeling commented 1 year ago

Thank you @eliasp for posting this issue and @MikeMcC399 for the PR! I merged the change and will close the PR for now. Forwarded the observation as well. Please reach out to us, should anything else occur.

MikeMcC399 commented 1 year ago

@brianebeling

I merged the change and will close the PR for now.

Did you really mean "for now" i.e. you expect to do something more with it later, or was that just a typo? As far as I am concerned the issue is permanently resolved. Similar things have happened in the past where organizations which were very active at the beginning of the pandemic later on ceased operations and their associated website went away, for instance https://github.com/corona-warn-app/cwa-documentation/pull/494.

brianebeling commented 1 year ago

Brian-J. Ebeling

I merged the change and will close the PR for now.

Did you really mean "for now" i.e. you expect to do something more with it later, or was that just a typo? As far as I am concerned the issue is permanently resolved. Similar things have happened in the past where organizations which were very active at the beginning of the pandemic later on ceased operations and their associated website went away, for instance #494.

No, just badly worded. For me this was a first and I was a bit surprised. PR also was the wrong term, issue of course. Although.. the PR is also closed. 😄