search

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
6 stars 5 forks source link

Change from #30 was not deployed #32

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Where to find the issue

EN: https://e.coronawarn.app/en/ DE: https://e.coronawarn.app/de/

Describe the issue

It seems like the change I did in #30 was never deployed to e.coronawarn.app or s.coronawarn.app.

Suggested change

The README says:

Updating the landing page

Any direct commits and merged pull requests will automatically trigger follow-up actions to build and deploy the changes to e.coronawarn.app and s.coronawarn.app. The respective GitHub Actions are available in the .github/workflows directory of this repository.

This seems to be either out of date or was never true, as in https://github.com/corona-warn-app/cwa-event-landingpage/actions I can only find the Build Page workflow, which is only the GitHub action for the check which runs on every commit in this repo. It is, however, not the workflow deploying the changes.

So I suggest to add a workflow, similar to the one which can be found in the https://github.com/corona-warn-app/cwa-website repository, which deploys the changes merged into main here, to the PROD server.

cc @dsarkar @thomasaugsten & @christianneu

Ein-Tim commented 2 years ago

@dsarkar Will you be able to look at this soon?

dsarkar commented 2 years ago

@Ein-Tim Will come back to you, thanks for the ping!

MikeMcC399 commented 2 years ago

@Ein-Tim I didn't know about this point as I don't follow this repository on a regular basis. Thank you for the pointer in https://github.com/corona-warn-app/cwa-website/issues/2098#issuecomment-984696982.

It should be clear how this web content is deployed, then the question about the use of the right node version could be looked at.

Perhaps the original site content was deployed manually and there is no mechanism in place to sync any updates into production?

Ein-Tim commented 2 years ago

@MikeMcC399

Perhaps the original site content was deployed manually and there is no mechanism in place to sync any updates into production?

Yes, I guess so. However, this would contradict what is written in the README.md file.

MikeMcC399 commented 2 years ago

@Ein-Tim

Perhaps the original site content was deployed manually and there is no mechanism in place to sync any updates into production?

Yes, I guess so. However, this would contradict what is written in the README.md file.

The README.md#updating-the-landing-page says:

"Updating the landing page

Any direct commits and merged pull requests will automatically trigger follow-up actions to build and deploy the changes to e.coronawarn.app and s.coronawarn.app. The respective GitHub Actions are available in the .github/workflows directory of this repository."

so yes, it seems the documentation describes the desired state, however this does not correspond to what .github/workflows actually contains.

.github/workflows/build.yml is the only script to be found in .github/workflows. There is no deploy-master.yml script or anything similar. As the name suggests, build.yml only builds the website. It does not deploy it anywhere.

thomasaugsten commented 2 years ago

It is not planned to deploy this part automatically

Ein-Tim commented 2 years ago

@thomasaugsten

Okay, thanks. So in the future, after a PR is merged, someone will deploy the change manually?

Can you do this for #30 and the updated copyright year?

thomasaugsten commented 2 years ago

The complete main branch will be deployed but it is a more complex process

thomasaugsten commented 2 years ago

Deployment is done