search

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
6 stars 5 forks source link

Missing social media links for landing pages #35

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Where to find the issue

Describe the issue

The footers of the websites:

are no longer aligned to the footer of the website:

The footers of https://e.coronawarn.app/ and https://s.coronawarn.app/ are missing the:

  1. Link to Social Media https://www.coronawarn.app/en/community/#social-media
  2. Link to Twitter https://twitter.com/coronawarnapp
  3. Link to Instagram https://www.instagram.com/rki_fuer_euch/

Footer of https://e.coronawarn.app/ and https://s.coronawarn.app/

s coronawarn app

Footer of https://www.coronawarn.app/

coronawarn app

Suggested change

Update the footers of the websites:

to display the same as the footer of the website:

including update to the latest Copyright year.

See in particular PR https://github.com/corona-warn-app/cwa-website/pull/2284 "Add social media icons and community section".

dsarkar commented 2 years ago

@MikeMcC399 Thanks for pointing this out.

Ein-Tim commented 2 years ago

@MikeMcC399

Do you plan to provide a PR for this? Else I could do it 🙂

MikeMcC399 commented 2 years ago

@Ein-Tim

I was not planning to provide a PR because first the issue about how this repository gets deployed needs to be solved. See your issue https://github.com/corona-warn-app/cwa-event-landingpage/issues/32.

Unless this other issue is solved no change here in the repository would cause a change to the website.

Ein-Tim commented 2 years ago

@MikeMcC399

You're right, I forgot!

Enjoy the weekend!

MikeMcC399 commented 2 years ago

@dsarkar

What are the thoughts about making this change?

I believe that the website is only displayed if the user doesn't have the app installed, so probably it will not be seen often.

It would however be more consistent to use the same footer as on the main website.

genericmueller commented 2 years ago

FYI: I just opened a CR for that and will bring it in production soon.

Ein-Tim commented 2 years ago

@genericmueller

Thank you! So you will deploy the main branch, or?

genericmueller commented 2 years ago

I have a feature branch right now for testing it on all (4) ENVs but in the end deployment will be done from the main branch, sure.

genericmueller commented 2 years ago

@Ein-Tim Hmm, I think I mixed something up here. Sorry. I have an internal branch for our deployment, but not in this repo. This repo here is only used to be part of a Docker image, which will then be deployed by us... But for now, the latest Image represents only the footer year changes as far as I see, not more... So someone needs to accept here the latest PRs and based on that create a new Docker image. Only then am I able to apply them to the Cluster.

Ein-Tim commented 2 years ago

@genericmueller Right, currently this issue from @MikeMcC399 was not addressed with a PR. Currently the last merged PR is #33 (updating the copyright year).

So what needs to be done is:

  1. Create a PR addressing this issue (@MikeMcC399 will you do this?)
  2. Create a new Docker Image
  3. You deploy the changes

FYI @dsarkar

MikeMcC399 commented 2 years ago

@genericmueller / @Ein-Tim

I suggest to look at PR https://github.com/corona-warn-app/cwa-website/pull/2284 from cwa-website and pick the changes which apply here. @brifemu was the author.

I wasn't planning to submit a PR myself for this.

genericmueller commented 2 years ago

@Ein-Tim / @MikeMcC399 I'm just trying to figure out, who's responsible for this topic. Seems to be someone from SAP, @thomasaugsten ?

dsarkar commented 2 years ago

@genericmueller We can provide and merge PRs. Concerning the social media in the footer, we will try by tomorrow to have a PR ready. Anything else needs to be done?

genericmueller commented 2 years ago

@dsarkar Thank you! Sounds good. We can take over after the new docker image is pushed into our registry (MTR)...

svengabr commented 2 years ago

@genericmueller I did add the footer changes to the main branch. Are you able to build the docker image and push it to the container registry or do you need someone to take care of it?

genericmueller commented 2 years ago

@svengabr Theoretically, I can also build the image, but it is the responsibility of my colleagues. It must first be checked and approved. The image is built through their build pipeline and is then pushed to the registry. After that, a deployment has to be planned and our environments have to go through to production :) Unfortunately, this is the normal way even with these minor adjustments. However, I will inform the colleagues that the image can be rebuilt and tested.

thomasaugsten commented 2 years ago

I will trigger the normal deployment process

MikeMcC399 commented 2 years ago

@svengabr I suggest to re-open this issue until the changes are deployed.

MikeMcC399 commented 2 years ago

Noting the comment from @thomasaugsten in https://github.com/corona-warn-app/cwa-event-landingpage/issues/32#issuecomment-1036025016 "Deployment is done" the social media links on the footers of:

are now updated and showing as follows:

image

So, now closing this issue as resolved.