Plans for this site? - Githubissues

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

6 stars 5 forks source link

Plans for this site? #36

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Is there any information about the plans for this site?

https://e.coronawarn.app/ relating to the Event Landing Page
https://s.coronawarn.app/ relating to the Rapid Antigen Test Landing Page

The site only displays if the user does not already have CWA installed and then its primary purpose is to prompt the user to install the app.

The site was manually cloned from https://github.com/corona-warn-app/cwa-website, stripped down in functionality, then modified to provide the needed functionality.

Issues

Since there is no live-link to code changes on https://github.com/corona-warn-app/cwa-website it now lags behind improvements made to cwa-website, for example:
- https://github.com/corona-warn-app/cwa-website/pull/2178
- https://github.com/corona-warn-app/cwa-website/pull/2284 (see also https://github.com/corona-warn-app/cwa-event-landingpage/issues/35)
There is no deployment script, so even if PRs are merged here, they do not automatically deploy to the production URLs (see above and related non-deployed PR https://github.com/corona-warn-app/cwa-event-landingpage/pull/30, also mentioned in issue https://github.com/corona-warn-app/cwa-event-landingpage/issues/32)

Suggestion

Clarify if it is necessary to keep the site up-to-date with the main production URL https://www.coronawarn.app/
If yes then:
Automate deployment
Manually add necessary PRs from https://github.com/corona-warn-app/cwa-website to this site, modifying them as required

MikeMcC399 commented 2 years ago

The issue regarding older gulp-sass and node-sass was resolved by https://github.com/corona-warn-app/cwa-event-landingpage/commit/8bfbfd636e78c2b3ec93bfa3005c14665fce6151 from @thomasaugsten. I can't find a PR for this change.
Missing social media links is being address through https://github.com/corona-warn-app/cwa-event-landingpage/issues/35.
The description regarding deployment was changed through PR https://github.com/corona-warn-app/cwa-event-landingpage/pull/39.

So the issues described have all been resolved.