search

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
7 stars 5 forks source link

Update documentation in README (No automatic deployment) #39

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

This PR updates the documentation reg. updating the landing pages.

Feedback is welcome!

svengabr commented 2 years ago

Thanks @Ein-Tim, the information regarding automatic deployments was infact, wrong.

MikeMcC399 commented 2 years ago

@Ein-Tim

I don't normally follow PRs on this site, so I didn't notice a typo before this was merged. If you are going to make changes I also have some suggestions for the grammar and formatting in addition to the one typo:

"Deploying of the chnages" => "Deployment of changes"

"Thus, even if a PR is merged into main here on GitHub , the change is not immediately visible on the pages, but only after the change was deployed."

=>

"Thus, even if a PR is merged into main here on GitHub, changes are not immediately visible on the pages, but only after the changes have been deployed."

Ein-Tim commented 2 years ago

@MikeMcC399

Thanks, I should've pinged you! 😅

I will provide a PR implementing your suggested changes & ping you so you can take a look. Thanks for the feedback!

MikeMcC399 commented 2 years ago

@Ein-Tim

I have subscribed to PRs from here now, so no need to ping me. I will get notified automatically.

Ein-Tim commented 2 years ago

That's even better 😄

Ein-Tim commented 2 years ago

PR: https://github.com/corona-warn-app/cwa-event-landingpage/pull/41