search

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
6 stars 5 forks source link

Update footer to align with coronawarn.app #51

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Description

This PR updates the footer to match the one from coronawarn.app.

What was changed?

The file global.json which includes the settings for the footer.

Screenshots

DE EN
Bildschirmfoto 2022-07-24 um 11 52 30 Bildschirmfoto 2022-07-24 um 11 52 38 
MikeMcC399 commented 2 years ago

@Ein-Tim

The https://www.coronawarn.app/en/accessibility/ page only refers to the website www.coronawarn.app.

The section of the README About this Repository says:

"This repository contains the source files of the official Corona-Warn-App landing page as it is available at e.coronawarn.app (for event-registration),s.coronawarn.app (for rapid antigen tests) & p.coronawarn.app (for rapid PCR tests)."

So there is no overlap between the Accessibility Statement URL coverage (www.coronawarn.app) and the URLs controlled by this repository ( e.coronawarn.app, s.coronawarn.app & p.coronawarn.app).

It would not be harmful to add the links in this PR, however I don't think it would be helpful.

Ein-Tim commented 2 years ago

@MikeMcC399

AFAIK the intention was to always keep the footer of the two pages aligned.

svengabr commented 2 years ago

LGTM

Ein-Tim commented 1 year ago

@MikeMcC399 Very strange. I took the screenshots of this PR on my environment using the build instructions from this repositories README. I did not encounter the problem you described, and which is visible on both your local environment and the Vercel preview deployment, when taking the screenshots. Any idea what's wrong here?

MikeMcC399 commented 1 year ago

@Ein-Tim

Any idea what's wrong here?

The site was never converted to be accessible and the code is missing.

In https://github.com/corona-warn-app/cwa-event-landingpage/issues/68#issuecomment-1409788189 I go into more detail and suggest to revert this PR.