search

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
6 stars 5 forks source link

Upgrade to Node 18 #55

Closed brianebeling closed 1 year ago

brianebeling commented 1 year ago

Also removes the dependency on node-sass and replaces it with sass

Tested locally by compiling, and live testing. No errors or warnings, outside the deprecation notices.

Testing the pipeline is wip

Internal Tracking ID: EXPOSUREAPP-14273

MikeMcC399 commented 1 year ago
MikeMcC399 commented 1 year ago

@brianebeling

In https://github.com/corona-warn-app/cwa-event-landingpage/blob/50ff774e6087cddcb128adb4d8fb32dde2cf164c/.github/workflows/build.yml#L24

I suggest you update to v3 See the equivalent PR https://github.com/corona-warn-app/cwa-website/pull/3161 cwa-website.

brianebeling commented 1 year ago

The checkout action should be updated to v3.

I also added a comment about using a cypress container. It is not necessary to change it, but if it were to be changed then it could be aligned with the cwa-website for easier future maintenance and understanding.

Thanks for the suggestions, good catch on the cypress container, that should be fixed now. PR is ready for review.

MikeMcC399 commented 1 year ago

@dsarkar / @brianebeling

What about https://github.com/corona-warn-app/cwa-event-landingpage/blob/main/Dockerfile which specifies:

https://github.com/corona-warn-app/cwa-event-landingpage/blob/0a83a665b2245a7a62cf086667031886128025c9/Dockerfile#L1

Is that relevant?

It is not documented in https://github.com/corona-warn-app/cwa-event-landingpage/blob/main/README.md

dsarkar commented 1 year ago

@MikeMcC399 Thanks, we will have a look tomorrow!

Ein-Tim commented 1 year ago

@thomasaugsten fixed that with https://github.com/corona-warn-app/cwa-event-landingpage/pull/59