References to TAN Hotline in footer

corona-warn-app / cwa-event-landingpage

Small event landing page for new CWA users when using the native camera. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

6 stars 5 forks source link

References to TAN Hotline in footer #66

Closed Ein-Tim closed 1 year ago

Ein-Tim commented 1 year ago

Where to find the issue

Footer of all pages on e.coronawarn.app, p.coronawarn.app & s.coronawarn.app "Hotline TAN"

Describe the issue

References to the TAN Hotline in the footer do not say that the hotline will be discontinued.

Suggestion

Remove the "Hotline TAN" paragraph on 01. Feb 2023.

References

coronawarn.app/en/blog/2023-01-18-cwa-3-0 says "... the operation of the verification hotline will be discontinued as of 31.01.2023."

Related issue

https://github.com/corona-warn-app/cwa-website/issues/3331

Internal Tracking ID: EXPOSUREAPP-14643

Ein-Tim commented 1 year ago

@dsarkar & @MikeMcC399

What would you think about a PR removing the dates from both this repositories code & cwa-websites code? I'd also adjust the relevant tests so that they don't fail.

dsarkar commented 1 year ago

@Ein-Tim Thanks for the suggestion, we will discuss this internally, Internal Tracking ID: EXPOSUREAPP-14643. Makes sense.

MikeMcC399 commented 1 year ago

@Ein-Tim

What would you think about a PR removing the dates from both this repositories code & cwa-websites code? I'd also adjust the relevant tests so that they don't fail.

Where are you seeing dates in this repository (https://github.com/corona-warn-app/cwa-event-landingpage)? There hasn't been any commit here since last year.

Regarding the cwa-website, I suggest to carry out the discussion in that repository. I don't see any urgency however as the presence of the date and the planned recorded message ensure that users are fully informed.

Ein-Tim commented 1 year ago

@MikeMcC399

Sorry for not being clear. I meant to propose the following:

remove hotline information from the footer of the websites which code is hosted in this repository
remove hotline information (& the newly added shutdown date) from the website https://coronawarn.app

As @dsarkar already opened an internal ticket for this suggestion, I will leave the issue here and not follow-up in the cwa-website repository, as information from the JIRA ticket will be provided to this GitHub issue. If there is further, cwa-website specific discussion needed, we can continue in a separate issue there.

dsarkar commented 1 year ago

@Ein-Tim Thanks again for bringing our attention to this issue. Indeed, the hotline telephone numbers should be removed in the footer. Do you want to provide a pull request?

Ein-Tim commented 1 year ago

@dsarkar

For sure! PRs follow later today!

dsarkar commented 1 year ago

@Ein-Tim Thanks, very much appreciated. I understand you will look also into the cypress test or you'd prefer if we do this?

Ein-Tim commented 1 year ago

@dsarkar

I will look into it, but can't guarantee that I will be able to keep them working correctly. But as far as I see, it's only this test: https://github.com/corona-warn-app/cwa-website/blob/master/cypress/e2e/hotline.cy.js that needs changing.

Ein-Tim commented 1 year ago

Hey there @dsarkar,

I provided two PRs:

https://github.com/corona-warn-app/cwa-event-landingpage/pull/67 for this repository
https://github.com/corona-warn-app/cwa-website/pull/3356 for the cwa-website repository

I also adapted the cypress tests myself!