search

corona-warn-app / cwa-map-public-frontend

Corona-Warn-App Map Public Frontend
https://map.schnelltestportal.de/
2 stars 2 forks source link

README issue? URL is http://localhost:9000 on my machine and not http://localhost:9090 building with `npm run serve` #12

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

For me the project was launched at http://localhost:9000 and not at http://localhost:9090 building the project locally. Is this is an issue in the README or is this environment dependent?

Ein-Tim commented 2 years ago

@dreske

I'd like to provide a PR for this issue. Could you try running the project on your environment and let me know what URL you get? :D

MikeMcC399 commented 2 years ago

@Ein-Tim

npm serve uses webpack https://github.com/corona-warn-app/cwa-map-public-frontend/blob/02ab69101816e8ccfdf1425a53b0c68b81900f49/package.json#L9

https://github.com/corona-warn-app/cwa-map-public-frontend/blob/02ab69101816e8ccfdf1425a53b0c68b81900f49/webpack.config.js#L48

defines port 9000

Ein-Tim commented 2 years ago

@MikeMcC399

Ok, so the README is wrong. I will create a PR on the week end.

Ein-Tim commented 2 years ago

I've not forgotten this issue and a PR will follow...

Ein-Tim commented 2 years ago

PR #15 provided.