corona-warn-app / cwa-map-public-frontend

Corona-Warn-App Map Public Frontend
https://map.schnelltestportal.de/
2 stars 2 forks source link

Address format errors in T-Systems International GmbH Impressum #23

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Where to find the issue

https://map.schnelltestportal.de/impressum.html

Describe the issues

  1. Addresses in Frankfurt and Bonn use the format "D-". This was deprecated in September 1999. See https://www.deutschepost.de/de/b/briefe-ins-ausland/laenderkuerzel-laendercode.html:

    "Was ist aus den Ländercodes geworden?
    Die Angabe der Länderkürzel vor der Postleitzahl bei der Adressangabe auf Briefen und Paketen wurde offiziell am 1. September 1999 abgeschafft."

  2. There is a hyphen between the street name and house number in "Friedrich-Ebert-Allee-140". There should be no hyphen there.

Suggestion

Change to

Hahnstraße 43d
60528 Frankfurt am Main, Germany

and

Friedrich-Ebert-Allee 140
53113 Bonn, Germany

Comment

https://www.t-systems.com/de/en/imprint and https://www.t-systems.com/de/de/impressum

also contain these formatting errors.

For comparison, refer also to https://www.telekom.com/en/deutsche-telekom/imprint-1742 from Deutsche Telekom AG which formats the addresses correctly i.e. no use of "D-" and no hyphen in the address in front of the house number "Friedrich-Ebert-Allee 140".

References

dreske commented 2 years ago

Thank you. I will change it.

Mike McCready @.***> schrieb am Mo., 5. Sept. 2022, 14:51:

Where to find the issue

https://map.schnelltestportal.de/impressum.html Describe the issues

1.

Addresses in Frankfurt and Bonn use the format "D-". This was deprecated in February 1999. See https://www.deutschepost.de/de/b/briefe-ins-ausland/laenderkuerzel-laendercode.html :

"Was ist aus den Ländercodes geworden?

Die Angabe der Länderkürzel vor der Postleitzahl bei der Adressangabe auf Briefen und Paketen wurde offiziell am 1. September 1999 abgeschafft." 2.

There is a hyphen between the street name and house number in "Friedrich-Ebert-Allee-140". There should be no hyphen there.

Suggestion

Change to

Hahnstraße 43d

60528 Frankfurt am Main

Deutschland

and

Friedrich-Ebert-Allee 140

53113 Bonn

Deutschland

Comment

https://www.t-systems.com/de/en/imprint and https://www.t-systems.com/de/de/impressum

also contain these formatting errors.

— Reply to this email directly, view it on GitHub https://github.com/corona-warn-app/cwa-map-public-frontend/issues/23, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7I3K6TIF4PKGDRVDBHM3V4XUGZANCNFSM6AAAAAAQE622LA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MikeMcC399 commented 2 years ago

@dreske

I will change it.

Thank you. I also sent mail to info@t-systems.com suggesting that they correct the main T-Systems Impressum page.

MikeMcC399 commented 2 years ago

@dreske

MikeMcC399 commented 2 years ago

@dreske

Thank you for merging! When will you push this (and other changes) to production?

dreske commented 2 years ago

Plan was today, but due some ops issued, we've moved to tomorrow.

Mike McCready @.***> schrieb am Do., 8. Sept. 2022, 10:41:

@dreske https://github.com/dreske

Thank you for merging! When will you push this (and other changes) to production?

— Reply to this email directly, view it on GitHub https://github.com/corona-warn-app/cwa-map-public-frontend/issues/23#issuecomment-1240410494, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ7I3K6426KH7CIQBRDNOLV5GRCHANCNFSM6AAAAAAQE622LA . You are receiving this because you were mentioned.Message ID: @.***>

MikeMcC399 commented 2 years ago

Closing, since the source is fixed and just waiting for move to production.