search

corona-warn-app / cwa-verification-server

Backend implementation of the verification process
Apache License 2.0
343 stars 105 forks source link

Registration token refactor #260

Open damirseit opened 2 years ago

damirseit commented 2 years ago

Addressing the issue described in the comments section of:

https://github.com/corona-warn-app/cwa-verification-server/issues/61

@alstiefel @dfischer-tech @f11h @jhagestedt @mlaue-tech @mschulte-tsi @tence @kreincke @ascheibal @BugBuster1701

f11h commented 2 years ago

Hi @damirseit ,

your code needs some style refactoring - please have a look in the build output here and fix these issues :) https://github.com/corona-warn-app/cwa-verification-server/runs/5356343880

You can also run mvn checkstyle:check to execute the style-checks locally.

damirseit commented 2 years ago

Hi @f11h!

Thank you! It feels like I have resolved all of the style warnings and pushed it to my branch. It is written here that I need a maintainer. How can I specify one, and can you be a maintainer for me? :)

Thanks in advance.

damirseit commented 2 years ago

@f11h @ascheibal Dear reviewers,

If you have some spare time, could you review my PR?

Thanks in advance!

f11h commented 2 years ago

Hi @damirseit, yes I will check your PR as soon as I have time for it :)

damirseit commented 2 years ago

Dear @f11h @ascheibal,

I am sorry to bother you again. If I have to make any changes, could you please let me know? Thanks in advance.