corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
521 stars 224 forks source link

Make bookmarking glossary entries easier #1673

Closed MikeMcC399 closed 3 years ago

MikeMcC399 commented 3 years ago

Where to find the issue

https://www.coronawarn.app/en/faq/#glossary "Glossary" https://www.coronawarn.app/de/faq/#glossary "Glossar"

Describe the issue

This is an enhancement request.

PR https://github.com/corona-warn-app/cwa-website/pull/1672 "Glossary anchors introduced bookmarks for glossary entries e.g. the URL https://www.coronawarn.app/en/faq/#glossary_business_rules links to the Glossary entry labelled "Business Rules".

image

A casual website user who would like to bookmark this entry has no easy means to find out the name of the anchor used.

Suggested change

Add a method for each Glossary entry to allow a user to find out the link to a Glossary entry and use it to bookmark or refer to it from elsewhere.

FAQ entries each have a "Link to this answer" line which can be used to bookmark or copy the link.

For example https://www.coronawarn.app/en/faq/#vac_cert_internet

image

Perhaps this could also be applied to glossary entries?


Internal Tracking ID: EXPOSUREAPP-9226

dsarkar commented 3 years ago

@MikeMcC399 Thanks for the suggestions. Fixed by #1677.

MikeMcC399 commented 3 years ago

@dsarkar

Fixed by #1677.

Thank you and @larswmh for the improvement. Once again though, the PR was merged so quickly (8 minutes this time), I had no time to comment, so I will close this issue and submit another one.

MikeMcC399 commented 3 years ago

@dsarkar

Unfortunately #1677 has an issue. The bookmarks it has created do not work.

Take for instance the glossary entry for Recovery Certificate:

image

Link to this entry produces https://www.coronawarn.app/en/faq/#recovery_certificate but that link doesn't work. It just brings up the FAQ search box without finding the Glossary entry.

The Glossary entry actually uses id="glossary_recovery_certificate" so the full link to this entry is https://www.coronawarn.app/en/faq/#glossary_recovery_certificate.

Here is the corresponding HTML source code:

                  <div class="tab-pane fade show mt-4" id="R" role="tabpanel" aria-labelledby="R-tab">
                    <h4 class="headline headline-heavy px-3" >R</h4>  
                        <div>
                          <h5 class="mt-4 px-3" id="glossary_recovery_certificate"><b>Recovery Certificate</b></h5>
                          <div class="px-3">The certificate of recovery is a => digital certificate issued for a person who has demonstrably recovered from COVID-19 and proved immunity by a PCR test.</div>
                          <p class="px-3"><a href="#recovery_certificate" class="faq-anchor">Link to this entry</a></p>
                        </div>
                  </div>

Let me know if you actually need a new issue or if you can work from the above error report.

dsarkar commented 3 years ago

@MikeMcC399 Thanks for reporting this issue, no need to open another issue.

MikeMcC399 commented 3 years ago

1678 depending on this issue being solved.