search

corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
522 stars 224 forks source link

Suggestion to change Analysis topic to "Dashboard" #2352

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Where to find the issue

Describe the issue

The topic text at the top of the pages

is called:

This does not fit with the text at the bottom of the pages which says:

Analyse

Furthermore, as brought up in PR https://github.com/corona-warn-app/cwa-website/pull/2331, there is a jarring difference on the German page between the menu text "Analysis" and the topic text "Analyse".

The term "Analysis" could in any case be considered a misnomer, since the data on the page is not analyzed, it consists solely of certain counts displayed in relation to dates.

Suggested change

Replace the topic text using "Dashboard" in English and in German. This resolves all discrepancies. Dashboard is also a better description of the display type of the data, which is not analyzed, only displayed.

The page is already being referred to elsewhere as a dashboard - see https://www.coronawarn.app/en/faq/#numbers_RKI.

Change these two lines:

https://github.com/corona-warn-app/cwa-website/blob/abe8f761c6a66ab1c757523bb20726d54bd153ef/src/data/analyse_en.json#L4

https://github.com/corona-warn-app/cwa-website/blob/abe8f761c6a66ab1c757523bb20726d54bd153ef/src/data/analyse_de.json#L4

to use the text "Dashboard".

The German page would then look like this:

Dashboard suggestion

Ein-Tim commented 2 years ago

I like this idea very much and would love to see this getting implemented! It makes the most sense, IHMO!

MikeMcC399 commented 2 years ago

@HelTob / @dsarkar

Would you agree to change the topic label to "Dashboard" at the top of:

like this:

Dashboard suggestion

It would be good to get your feedback.

MikeMcC399 commented 2 years ago

@Ein-Tim Just a small side-question: when you write "IHMO" do you mean "In My Humble Opinion", because it that case the abbreviation would be "IMHO" or is there some other meaning for "IHMO"?

Ein-Tim commented 2 years ago

@MikeMcC399

I know "IHMO" as the abbreviation for "In My Honest Opinion" 🙂

I should rather use IMO, I guess (-;

MikeMcC399 commented 2 years ago

@Ein-Tim

The order of the letters I H M O does not spell "In My Honest Opinion" either.

Ein-Tim commented 2 years ago

@MikeMcC399

Right, my life is a lie! 😀

I will use IMO ("In my opinion") in the future, thanks for making me aware of this!

Ein-Tim commented 2 years ago

@MikeMcC399 Another Off Topic comment, sorry, I remember yesterday someone shared an article from "WELT" that RKI now calls 2 times vaccinated people no longer "Fully vaccinated" but something else. You did some research on this, but I can't find it anymore. Would you be so kind and link the comment? Thanks!

MikeMcC399 commented 2 years ago

@Ein-Tim It was an off-topic post in issue 3698 of the Android repo. I don't want to post the full hyperlink here, otherwise GitHub will autolink the issues.

Ein-Tim commented 2 years ago

@MikeMcC399 Okay, thank you! No more off-topic comments now! 😉

MikeMcC399 commented 2 years ago

@browkin

Do we need agreement from anybody else to implement this change? For example from @HelTob?

dsarkar commented 2 years ago

@MikeMcC399 We forwarded this suggestion. Thanks!

HelTob commented 2 years ago

Hi there,

thank you very much for your suggestions. We are discussing the topic internally and will adjust the title of the page as soon as possible.

Best regards, Tobias

MikeMcC399 commented 2 years ago
dsarkar commented 2 years ago

@MikeMcC399 PR merged. Thanks for the suggestion!

MikeMcC399 commented 2 years ago

Closing as this suggestion is now implemented.