search

corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
522 stars 225 forks source link

Bump copyright year in README.md #3299

Closed Ein-Tim closed 1 year ago

Ein-Tim commented 1 year ago

Description

This PR bumps the copyright year in the README.md file.

Happy new year! 🎉

Note

This PR should only be merged once a change to any content of this repository was done.

Internal Tracking ID: EXPOSUREAPP-14521

MikeMcC399 commented 1 year ago

@brianebeling

Same as in the other PRs of the same kind already, thanks for the change. I was unable to find more places that would require a change.

Happy New Year!

What about https://github.com/corona-warn-app/cwa-website/blob/master/NOTICE? I don't know if this file even makes sense in fact.

There are various opinions on the Internet about whether it is legally necessary to update Copyright notices on websites or not. That would be a question for the lawyers. It does however give readers an idea about whether the website is up-to-date or not.

Ein-Tim commented 1 year ago

@MikeMcC399 To me, it looks like the NOTICE file of this repository was never correctly established. When comparing the file from this repository to the file in the documentation repository , it looks like the contributors are missing. But also there, in the documentation repo, the copyright year has never been changed. I'm unsure if this file is really relevant.

brianebeling commented 1 year ago

Honestly, I'm not sure. I will forward it and let you know.

I'd suggest we merge this and make a separate PR for the notice.

Also Happy New Year to both of you. I will be on vacation for around two weeks and only check in here irregularly, but @dsarkar is back in action. 🎉

MikeMcC399 commented 1 year ago

@Ein-Tim / @brianebeling

https://www.apache.org/licenses/LICENSE-2.0 in the section "HOW TO APPLY THE APACHE LICENSE TO YOUR WORK" says: "Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file that references the License."

however since the suggested text is already in the README, Licensing section and NOTICE is incorrectly completed, then I suggest that the NOTICE file is deleted as part of any Copyright update review.

MikeMcC399 commented 1 year ago

@larswmh

If the README only refers to itself:

"Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License."

and the NOTICE file refers to "them" without specifying what "them" means as in:

"you may not use them except in compliance with the License."

then this should be cleaned up.

My reading of opinions about Copyright notices says that they are not really necessary, so if they are not necessary, then it doesn't matter if they are clean or not, however this should be sorted out by legal experts.

Thank for passing on the concerns in any case.