Update workflows: Include build job into build-and-test

corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

522 stars 225 forks source link

Update workflows: Include build job into build-and-test #3324

Closed larswmh closed 1 year ago

larswmh commented 1 year ago

This PR modifies the build-and-test.yml workflow so that it includes two jobs:

build: the required job to merge PRs into master
test: the optional job to test PRs with Cypress

Internal Tracking ID: EXPOSUREAPP-14535

MikeMcC399 commented 1 year ago

@larswmh

It's interesting to see in https://github.com/corona-warn-app/cwa-website/pull/3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

larswmh commented 1 year ago

@MikeMcC399

It's interesting to see in #3323 that the "build" job is required and the "test" job is not required. Again, I'm guessing that this is part of the branch protection rules which are not visible to me.

In the branch protection rules, the build job is set as required. Not the build.yml workflow file. This way I could just move the job to the build-and-test.yml without problems.

MikeMcC399 commented 1 year ago

@larswmh

Thank you for the screenshot! I imagined that it must be like this, however I had no way to view it.

It might be good at a later stage to add the test job to the required positive status outcomes. It is probably good for the moment not to require it, until there is more experience with the job. Whoever merges a PR can make the decision manually if they want to merge a PR which fails the Cypress test (like https://github.com/corona-warn-app/cwa-website/pull/3321).