corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
521 stars 224 forks source link

Cypress video check on directories without videos #3397

Closed MikeMcC399 closed 1 year ago

MikeMcC399 commented 1 year ago

Where to find the issue

cypress/e2e/check_videos.cy.js

Describe the issue

The Cypress test cypress/e2e/check_videos.cy.js searches in the web directories for HTML <video> elements.

There are currently 20 such elements in cwa-website located in:

Many of the directories checked, such as /en/sitemap/ do not contain any video content and are never expected to contain any video content in the future. This causes unnecessary checking.

Steps to reproduce

npm run test:open

select check_videos

Suggestion

Remove directories from the list to check in the cypress/e2e/check_videos.cy.js test spec, where there are no videos located and there are none to be expected:

        '/de/eventregistration/',
        '/en/eventregistration/',
        '/de/community/',
        '/en/community/',
        '/de/analysis/',
        '/en/analysis/',
        '/de/blog/archiv/',
        '/en/blog/archive/',
        '/de/screenshots/',
        '/en/screenshots/',
        '/de/rat-partner/',
        '/en/rat-partner/',
        '/de/privacy/',
        '/en/privacy/',
        '/de/terms-of-use/',
        '/en/terms-of-use/',
        '/de/event-qr-code-guide/',
        '/en/event-qr-code-guide/',
        '/de/simple-language/',
        '/en/simple-language/',
        '/de/sitemap/',
        '/en/sitemap/'

Benefit

MikeMcC399 commented 1 year ago