search

corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
522 stars 225 forks source link

Add callouts to FAQ entries for updates #3423

Closed brianebeling closed 1 year ago

brianebeling commented 1 year ago

Where an update text was available, there are now callouts for the updated FAQ entries image

There are no callouts for entries, where there was no update text already provided, example: image

There are also no callouts for texts that are structured like this: "Since version 2.5 [..], and since version 2.6" and contain a lot of text. As that would essentially make the whole entry a callout. Callouts are meant to highlight changes to the faq entry, not necessarily the app version.

(merging this soon already, but if there is feedback, please don't hesitate to write it into the already closed pr)

MikeMcC399 commented 1 year ago

@brianebeling

There are bad links in this PR, which is why it fails the test faq_link_attr.

You need to change target='blank' to target='_blank'.

image

brianebeling commented 1 year ago

Thanks @MikeMcC399 and sorry for the oversight, I'm a bit under pressure at the moment

MikeMcC399 commented 1 year ago

@brianebeling

Unfortunately merging PRs too fast can lead to errors being missed, causing extra rework.

MikeMcC399 commented 1 year ago

https://www.coronawarn.app/de/faq/results/#vac_booster_jj is displayed incorrectly due to a tag which isn't closed. See in-line comment.

brianebeling commented 1 year ago

I fixed all the mistakes. Thanks @MikeMcC399!