corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
522 stars 225 forks source link

Update dashboard: Add annotations for Warning without TAN #3434

Closed larswmh closed 1 year ago

larswmh commented 1 year ago

This PR adds an annotation to the dashboard to show when "Warning without TAN" was implemented into the app. This will help to understand why the statistics in the lower two tiles have significantly changed after this date.

image


Internal Tracking ID: EXPOSUREAPP-14711

MikeMcC399 commented 1 year ago

@larswmh

This is a good for the first transition, however it would need also the second transition on March 1, 2023 to be flagged as well.

image

After March 1, 2023 significantly less tests are being done due to legal changes in TestV. See also https://github.com/corona-warn-app/cwa-website/issues/3415.

Otherwise it would be difficult to interpret and understand the peak and drop-off of numbers.

larswmh commented 1 year ago

@MikeMcC399

This is a good for the first transition, however it would need also the second transition on March 1, 2023 to be flagged as well.

image

After March 1, 2023 significantly less tests are being done due to legal changes in TestV. See also #3415.

Otherwise it would be difficult to interpret and understand the peak and drop-off of numbers.

We agree that there should be another annotation for the legal changes in TestV. We already forwarded your suggestion yesterday and got positive feedback. This will be added in a PR soon, however we would like to merge this PR now.

MikeMcC399 commented 1 year ago

@larswmh

We agree that there should be another annotation for the legal changes in TestV. We already forwarded your suggestion yesterday and got positive feedback. This will be added in a PR soon, however we would like to merge this PR now.

Many thanks for picking up my suggestion!

I would personally want to add the two annotations together, but of course it's your decision if you want to go ahead with this PR on its own.