Closed larswmh closed 1 year ago
Is there a benefit from keeping the out-of-date texts visible? Have you considered deleting FAQ articles which are no longer applicable?
Also, as seen by issue https://github.com/corona-warn-app/cwa-website/issues/3475 external links will deteriorate over time. It seems that other "webmasters" feel no responsibility for maintaining links to obsolete content and simply delete pages, leaving an HTTP 404 not found
error behind. The more content (with links) you leave online, the more maintenance you will need to do to keep the weekly link tests from not failing.
@MikeMcC399
- Is there a benefit from keeping the out-of-date texts visible? Have you considered deleting FAQ articles which are no longer applicable?
Deleting FAQ entries was taken into consideration, but keeping them all was preferred to keep the site as a sort of archive now that the app is slowly shutting down. If anyone is interested, they will be able to look through everything that has been possible with the app in the future.
- Also, as seen by issue Broken link zusammengegencorona wann-muss-ich-in-quarantaene-und-wann-nicht #3475 external links will deteriorate over time. It seems that other "webmasters" feel no responsibility for maintaining links to obsolete content and simply delete pages, leaving an HTTP
404 not found
error behind. The more content (with links) you leave online, the more maintenance you will need to do to keep the weekly link tests from not failing.
That is correct, but I don't think it's that much of an issue, especially if there's a box above the FAQ stating that the content is outdated. For the time being, we will still actively monitor this repository, and the automated weekly check for broken links really helps us with that.
@larswmh
Thank you for explaining why you want to keep the contents. Of course it is your decision about this. I would have preferred the non-active contents to be removed instead of hoarding it. (There is a web wayback machine which serves the interests of those looking for historical contents e.g. https://web.archive.org/web/20230327123134/https://www.coronawarn.app/en/.)
I noticed that the test faq_link_attr
failed a couple of times. I could not find the reason for this and it is now working again. It was only failing on GitHub, not locally. You may need to keep an eye on this. Due to this PR it is now checking around 700 links in the each language main FAQ section. This is ~40% more than before.
@larswmh
There is no longer a "Settings" option in the CWA menu, so any FAQ article, such as https://www.coronawarn.app/en/faq/results/#notification_settings which includes instructions to tap on "Settings" is now obsolete.
@MikeMcC399
There is no longer a "Settings" option in the CWA menu, so any FAQ article, such as https://www.coronawarn.app/en/faq/results/#notification_settings which includes instructions to tap on "Settings" is now obsolete.
Thanks for the information, I've added the box to #notification_settings in https://github.com/corona-warn-app/cwa-website/pull/3474/commits/56670c124eea317928e07f12f6fcbc1cf2f038b9
This PR adds the blue info box to 213 FAQ entries, as the Corona-Warn-App functionality is being heavily reduced. Thus, every FAQ entry that covers a soon to be disabled functionality, or is related to it in any way, received the blue box.
While reviewing, you might come across some changes that are not really related to the opening comment, but were practical to implement with this massive batch of changes all together. This includes:
#multiple_exposure_checks
and#ENError5
to match their placement across both languages<hr />
to avoid confusion.#admission_policy
was also added to#admission_policy_2gplus
,#admission_policy_2gplus_booster
,#admission_policy_2gplus_booster_howto
and#admission_policy_2gplus_not_shown
#dashboard_pcr_tests
#update_faq
was modified to represent the date of when this change will take effectInternal Tracking ID: EXPOSUREAPP-13612