corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
523 stars 225 forks source link

Test Links workflow always fails #3478

Closed MikeMcC399 closed 1 year ago

MikeMcC399 commented 1 year ago

Suggestion

Since it was decided to no longer maintain links, the workflow will always fail.

The suggestion is to disable the workflow

https://github.com/corona-warn-app/cwa-website/blob/f46176e9c2c76876ea45bb8cf9aba3a13569541f/.github/workflows/test-check_links.yml#L10-L12

See Disabling and enabling a workflow.


Internal Tracking ID: EXPOSUREAPP-15134

MikeMcC399 commented 1 year ago

See for instance Job 4848120363:

image

larswmh commented 1 year ago

Thanks for your suggestion @MikeMcC399. We've disabled the workflow for now.

MikeMcC399 commented 1 year ago

@larswmh

The organization needs to make a decision about which pages on the website will be maintained and which pages are allowed to have errors. I have some ideas about how to modify the Cypress tests for this, so let me know if you want some assistance. So long as the website continues to operate, it should use Cypress to help maintain as much quality as is necessary.

larswmh commented 1 year ago

@MikeMcC399

The organization needs to make a decision about which pages on the website will be maintained and which pages are allowed to have errors. I have some ideas about how to modify the Cypress tests for this, so let me know if you want some assistance. So long as the website continues to operate, it should use Cypress to help maintain as much quality as is necessary.

Thanks for offering your assistance! We also think that Cypress tests should continue to operate as much as possible. What we're thinking of is only checking FAQ entries that are not declared as outdated.

MikeMcC399 commented 1 year ago

@larswmh

Thanks for offering your assistance! We also think that Cypress tests should continue to operate as much as possible. What we're thinking of is only checking FAQ entries that are not declared as outdated.

You also have to consider blogs which will age and over time some of their links can also be expected to fail.