search

corona-warn-app / cwa-website

Corona-Warn-App website. The CWA development ended on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
524 stars 225 forks source link

One more e-mail-address change #3526

Closed Ein-Tim closed 1 year ago

Ein-Tim commented 1 year ago

Description

This PR changes one more instance where the SAP mail address has been used.

MikeMcC399 commented 1 year ago

@Ein-Tim

What about https://github.com/corona-warn-app/cwa-website/blob/28ff46ebccdc52c535a0e07dac8c16dafc9547d8/package.json#L30

"author": "SAP Corona-Warn-App Open Source Team corona-warn-app.opensource@sap.com",

Ein-Tim commented 1 year ago

@MikeMcC399 Thanks for the hint!

As I'm not familiar with how the information in this file is used, I will need advice from @dsarkar here. As a reminder: We also decided to not change https://github.com/corona-warn-app/cwa-website#licensing, so maybe this is also ok for the package.json file?

MikeMcC399 commented 1 year ago

@Ein-Tim

According to https://docs.npmjs.com/creating-a-package-json-file#author-field "email and website are both optional"

so I suggest either to remove the sap e-mail address (since it is no longer reachable) or to completely replace the author by RKI with their e-mail address.

The licensing is OK not to be changed.

dsarkar commented 1 year ago

@Ein-Tim As @MikeMcC399 suggests: