Closed MikeMcC399 closed 3 years ago
@MikeMcC399 actually, what do you think about extending your proposal:
@dsarkar
what do you think about extending your proposal:
- Additionally, the notification should remind at that stage to get a teleTAN from the hotline.
That is not the right time to be proposing requesting a teleTAN. At the time of scanning a QR code, the user is registering a Corona test. They do not (normally) know yet if the test is positive. A teleTAN should only be requested if the user has already received a positive test result and:
So, no the proposal should not be extended.
I disagree. I already heard from some people that there are some labs who only issue the QR-Code when somebody is tested positive (yes, I know this is not how it is supposed to work - but I think the labs are doing this because they have too much work to do). If now the QR-Code the lab issued after the test was positive is not a valid CWA QR-Code, I don't think there would be a problem with adding (for example):
"If you know that you have tested positive for COVID-19, you can call the Verification Hotline to get a TeleTAN and warn other users."
to the error message.
But it's your proposal so of course you decide, just wanted to add that. 🙂
@Ein-Tim / @dsarkar I take your comments on board. So yes, add the point to recommend requesting a TAN (in the app it is not called teleTAN) if the user has already received a positive test result.
@MikeMcC399 @Ein-Tim
Understood.
I will include this in your proposal as you agreed already.
Thanks everybody!
Internal Tracking ID: EXPOSUREAPP-4721
Updates will be published here.
The error message has changed with version 1.12: https://github.com/corona-warn-app/cwa-app-ios/issues/1386#issuecomment-777437011
Actually, the message text was implemented earlier!
@Ein-Tim
If you compare the message in the original post #343 with the one you referred to from https://github.com/corona-warn-app/cwa-app-ios/issues/1386#issuecomment-777437011 you will see that they are identical.
I did not research iOS, but for Android the message with id submission_error_dialog_web_test_paired_body
has been in exactly this form since CWA Android 1.9.1. See https://github.com/corona-warn-app/cwa-app-android/blob/5bfc89c1d91bf8afd6aa610dbd611b4515d30e46/Corona-Warn-App/src/main/res/values/strings.xml#L753-L754
The point about this wishlist item (#343) is to distinguish between a wrongly formatted QR code and a QR code which has already been used. The two different cases should cause two different and appropriate error messages to be displayed.
Okay, this was a bad one from me.
Sorry, I mixed things up.
I'm so sorry for the confusion. 😕
new ticket EXPOSUREAPP-4406
It looks like this issue will be addressed by CWA 2.11 in Android where there is a universal QR code scanner under development. The current CWA 2.11 Android branch under development outputs the error message "Kein geeigneter QR-Code" when scanning the following random QR code containing the text "DE12345678" which is not related to any CWA standard QR code:
I'll look at this again when some more of the development work has been completed for 2.11.
I looked at the scan QR code function in the Android pre-release version 2.11.0-RC0 (commit https://github.com/corona-warn-app/cwa-app-android/commit/a79fb7b3e1e690b3d667906adb913f10cab14343) when scanning the non-CWA QR code "DE12345678" from the image https://user-images.githubusercontent.com/66998419/105467552-25905d80-5c96-11eb-8408-b4835ee6d61f.png displayed on another device.
The warning message which comes up says "No suitable QR code". That would fulfill the needs of this issue when the functionality is released.
There are some minor issues with the error text:
The "DETAILS" option leads to a stack trace. This is not optimal as the outcome of a user error. If the "DETAILS" option led to the display of the QR code contents in text form this might help troubleshooting. Alternatively the error message could link to a new FAQ entry which explains in more detail which QR codes can be scanned.
I don't know whether this feature is supposed to be finished or not. If yes, then I should probably submit issues into cwa-app-android, otherwise I will wait.
The original issue has been resolved with the Android 2.11 release. Internal Tracking ID: EXPOSUREAPP-4406
Some more improvements are needed though and these are covered in the separate issues:
I will leave this open for the moment in case there is any feedback on the iOS 2.11 release in this area.
I will leave this open for the moment in case there is any feedback on the iOS 2.11 release in this area.
Hello There 😉
iOS shows "The QR code is not supported by the Corona-Warn-App. Please scan a suitable QR code." when attempting to scan the QR code @MikeMcC399 shared in his comment above.
From my point of view, this issue can be closed.
Closing.
Android issues being followed separately, see https://github.com/corona-warn-app/cwa-wishlist/issues/343#issuecomment-936580161.
@MikeMcC399 Thanks, I forwarded your comment https://github.com/corona-warn-app/cwa-wishlist/issues/343#issuecomment-936580161 into the original internal ticket. Good night!
Current Implementation
Some labs issue QR codes after Corona testing which use a system that is not compatible with CWA QA codes (see https://github.com/corona-warn-app/cwa-wishlist/issues/270#issuecomment-764986222).
If a user scans such a QR code the error message is correct, but it doesn't distinguish between a foreign QR code and a CWA QR code which has already been registered.
Steps to reproduce
First reported on CWA Android version: 1.10.1 Reviewed not yet fixed on App version: 2.10.1 Issue is currently affected by work on App version: 2.11.x
This QR code contains the text "DE12345678"
Suggested Enhancement
The scanned QR code should be checked locally in the app to determine whether it has the right format.
The format should be https://localhost/?XXXXXX-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX for instance https://localhost/?3D6D08-3567F3F2-4DCF-43A3-8737-4CD1F87D6FDA
If the QR code does not correspond to this format, then the error message should say so, and should not say that the code might have been registered on another smartphone already.
A special case could also be made if the user somehow had access to the 10C/OECD lab form and scanned this in. The format of the the lab QR code is XXXXXX-XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX for instance 3D6D08-3567F3F2-4DCF-43A3-8737-4CD1F87D6FDA
If the QR code scanned in is not recognizable as a CWA QR code, then the app could display an example of a correct form (Muster 10C).
If the user determines that they have attempted to scan in a CWA QR code from the correct form, and the QR code is rejected due to formatting issues, the user should be advised where they can report this problem.
Expected Benefits
Clearer differentiation of error conditions leading to better user satisfaction and resolution.
References
15. DEZEMBER 2020 VERSION: 1.0419. MÄRZ 2021 VERSION: 1.0525. MAI 2021: 1.0624. AUGUST 2021: 1.07
Internal Tracking ID: EXPOSUREAPP-4406