QR-Code should have a black background in darkmode

corona-warn-app / cwa-wishlist

Central repository to collect community feature requests and improvements. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

105 stars 14 forks source link

QR-Code should have a black background in darkmode #511

Open jucktnich opened 3 years ago

jucktnich commented 3 years ago

Current Implementation

The QR-Code has has a white background on light- and darkmode.

Suggested Enhancement

Use a dark background.

Expected Benefits

Just looks better IMO.

Other

(An inversion of the qr-code picture should be easy to implement)

Internal Tracking-ID: EXPOSUREAPP-7301

Ein-Tim commented 3 years ago

@jucktnich Are you only asking for the RAT Profile QR-Code or also for the event-registration QR-Code? If you are only asking for the RAT Profile, why don't you think an implementation for the event-registration should be considered?

jucktnich commented 3 years ago

See #512

Ein-Tim commented 3 years ago

@jucktnich I saw #512 but it does not mention dark mode. The new title is better. Thank you!

jucktnich commented 3 years ago

Yeah, a bit confusing

Ein-Tim commented 3 years ago

Now it's clear, thanks! Supporting this btw!

heinezen commented 3 years ago

@jucktnich

Thank you for the request. We have created EXPOSUREAPP-7301 in our internal Jira for ypur proposal. The devs will discuss the possibility now.

Corona-Warn-App Open Source Team

AdamVB commented 3 years ago

Yesterday I was in the Airport in Malta and the Health Authority there had Issues scanning the Vaccination Certificate while the Phone (iOS) was in dark mode (max brightness). After setting it to light mode their app could scan the Vaccination Cert right away. So maybe a black background is not always the best idea. This might need more testing.

dsarkar commented 3 years ago

@AdamVB Thanks for the info. We will forward this internally.

Corona-Warn-App Open Source Team

jucktnich commented 3 years ago

@AdamVB the qrcode wasn't inverted right?

AdamVB commented 3 years ago

no, we tried it in all angles, even putting paper above both phones to avoid light reflexions but none of that helped until a colleague came by and gave the hint that turning on the "light" mode works a lot better. And as soon as we did that it scanned instantly.

jucktnich commented 3 years ago

@AdamVB you used the CWA right?

AdamVB commented 3 years ago

yes, displayed the QR Code from within CWA,

but i don't know what App the maltese authorities were using. But they all had the same phones/devices for scanning.

jucktnich commented 3 years ago

Yeah, but then this has nothing to do with my issue, I think, since my proposal wasn't implemented yet. Or do I miss something?

AdamVB commented 3 years ago

Well right now the background is dark grey so maybe it is already implemented?

jucktnich commented 3 years ago

My proposal is to invert the picture of the qr-code, not make the background black, since as you can see, this is and was already implemented.

AdamVB commented 3 years ago

ohh, i thought you meant the borders and background around the QR code, not the QR code content itself. Ok then my concerns are not in the right place here.