search

corona-warn-app / cwa-wishlist

Central repository to collect community feature requests and improvements. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
105 stars 14 forks source link

Add a timestamp to error messages (especially when error occurs from background process) #589

Closed ndegendogo closed 2 years ago

ndegendogo commented 3 years ago

Current Implementation

Currently, error messages are displayed without any timestamp. When an error occurs during background processing, the message is displayed only much later. This makes it hard to analyse the root cause of such an error.

Suggested Enhancement

The error message should be composed with a timestamp. This is especially usefull if the error happens during background processing, e.g. risc check.

Expected Benefits

In some cases, especially for errors occurring during background processing, the timestamp of the root cause of the failure would give us more context and help with error analysis.

Internal Tracking ID: EXPOSUREAPP-10190

ndegendogo commented 3 years ago

See also this comment

ndegendogo commented 3 years ago

@dsarkar @heinezen

Please ask the devs what they think of this idea. I would volunteer for a PR, but only for iOS, not for Android. I would limit the timestamp to error codes from ENF.

I hope that this could help to give insights, especially on error 13

ndegendogo commented 2 years ago

@dsarkar @heinezen I didn't get any feedback on this proposal for a long time.

Recently I got again ENF error 13. I saw the error message when I opened cwa in the morning; at this time my ENF log shows a successful risk check. However, in the night before I have an empty ENF log entry. So I have the suspicion: maybe the error message is related to the empty log entry in the night? In my opinion it would be extremely helpful to confirm (or reject) this suspicion.

So I implemented the extended error message according to this proposal and submitted PR #3749 (only for iOS). We can as well discuss the pros and cons of such a timestamp directly in the PR. Please add the label so the developers are not confused. Thanks!

dsarkar commented 2 years ago

@ndegendogo Good morning! We forwarded you comment together with the proposal and PR! Thanks!

ndegendogo commented 2 years ago

cwa version 2.14.1 (0) was rolled out. Closing this as fixed.

dsarkar commented 2 years ago

@ndegendogo Thanks again for the PR. Apparently this feature made already happy at least one tester. ;-)

ndegendogo commented 2 years ago

Apparently this feature made already happy at least one tester. ;-)

@dsarkar really?! 😅🎉