search

corona-warn-app / cwa-wishlist

Central repository to collect community feature requests and improvements. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
105 stars 14 forks source link

Do not show "Exposure check failed" screen if no new event IDs can be downloaded because the device is not connected to the internet #662

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 3 years ago

Current Implementation

Currently, the app shows the "Exposure check failed" card if a user was/is checked in to an event and the device is not connected to the internet. The reason for this is that the app tries to download new Event IDs as often as possible & performs a risk check with the IDs. This is quite confusing, as the Bluetooth based risk check is only carried out all 4h and the app does not show "Exposure check failed" if the device is not connected to the internet at the moment the check should be performed (or until up to 24h after the last successful check).

Suggested Enhancement

Don't show the "Exposure check failed" screen if no new event IDs can be downloaded because the device is offline. You don't do this when no new random IDs can be downloaded, so why should you do this if no new event IDs can be downloaded?

Expected Benefits

This is very confusing for the end user, who will ask the question whether the app still works offline or if they always have to be online to use the app.

Related Issues

Internal Tracking ID: EXPOSUREAPP-10997

dsarkar commented 2 years ago

@Ein-Tim thanks.

Internal Tracking ID: EXPOSUREAPP-10997

Corona-Warn-App Open Source Team

dsarkar commented 2 years ago

@Ein-Tim FYI, not sure, but this story might become obsolete/fixed with https://github.com/corona-warn-app/cwa-app-ios/pull/4017.

Ein-Tim commented 2 years ago

PR https://github.com/corona-warn-app/cwa-app-ios/pull/4598 fixes this under iOS.

@dsarkar Feel free to apply the Fix 2.24 label here.

Ein-Tim commented 2 years ago

I can confirm that this has been addressed in version 2.24 under iOS, I will check Android as soon I receive the update on the device.

mtwalli commented 2 years ago

@Ein-Tim This issue has been fixed also in Android in 2.26.0, please close the issue ?

Ein-Tim commented 2 years ago

@mtwalli As I commented above, I'd like to test this myself and will close this issue as soon as I can confirm the fix.

mtwalli commented 2 years ago

Ok, 2.26 is fully rolled out, Hopefully you should have received it by now

Ein-Tim commented 2 years ago

Confirm fixed. Closing.