corona-warn-app / cwa-wishlist

Central repository to collect community feature requests and improvements. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
105 stars 14 forks source link

Improve consistency checks and warning messages for certificates #782

Open ndegendogo opened 2 years ago

ndegendogo commented 2 years ago

Avoid duplicates

Current Implementation

If the date of issuance of the 3rd certificate for a person is before the second cert, this is unexpected. However, cwa ignores that silently, and sets the latest cert of a group as current. See here for an example.

Suggested Enhancement

Implement more consistency checks on the grouped certificates, and show a warning message to the user (please only a warning, not an error).

some kind of message like "date of 3rd vacc. cannnot be before the date of 2nd cert." would have helped

Expected Benefits

Note: the described behavior was seen on iOS. Not sure about the Android implementation. Feel free to move this ticket if appropriate.


Internal Tracking ID: EXPOSUREAPP-11740

dsarkar commented 2 years ago

@ndegendogo Although the idea is nice I am not sure if that is the right approach. Maybe it's trying to fix things on the wrong end. Maybe some consistency check should be implemented rather at the issuer. Anyway, of course, your suggestion will be forwarded!

Best wishes, DS

svengabr commented 2 years ago

Internal Tracking ID: EXPOSUREAPP-11740

ndegendogo commented 2 years ago

Maybe some consistency check should be implemented rather at the issuer

Who is the issuer then?