search

corona-warn-app / cwa-wishlist

Central repository to collect community feature requests and improvements. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
106 stars 14 forks source link

Don't send expiring soon notification for certificates that are not currently used #828

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Current Implementation

The app sends a notification to inform the user that a certificate is about to expire, regardless whether the certificate is the currently used one or not.

Suggested Enhancement

Do not send this notification if the certificate about to expire is not the currently used one. There is no benefit for normal users from this notification and it causes confusion (e.g. do I need to get my certificate reissued, do I have to get a booster, etc.).

Expected Benefits

Less confused users, some examples of confused users:

Additional information

This is a time sensitive issue. I therefore request prioritized mirroring to JIRA & assessment by the team.

Pings

Open-Source-Team: @dsarkar & @larswmh FYI: @mlenkeit & @Thomasaugsten

thomasaugsten commented 2 years ago

A deployment to disable the notification and banner is already prepared and will be deployed tomorrow

Ein-Tim commented 2 years ago

@thomasaugsten Thanks for the information! Does this change disable the notifications forever or only until version 2.23 is released?

BTW: Do you have a link to the corresponding server PR? I only found https://github.com/corona-warn-app/cwa-server/pull/1824, which delays the notification for one day.

thomasaugsten commented 2 years ago

This kind of notification. will be disabled forever only relevant certificate will send a push notification with 2.23 Its a configuration adjustment no server pr is needed here but we will sync the application yml after it is on production

Ein-Tim commented 2 years ago

@thomasaugsten Okay, thanks for the information, so IIUC, my proposal will be implemented with version 2.23?

Its a configuration adjustment no server pr is needed here but we will sync the application yml after it is on production

👍

thomasaugsten commented 2 years ago

Correct

Ein-Tim commented 2 years ago

Thanks for your fast responses @thomasaugsten.

@dsarkar I suggest to add the Fix 2.23 label here.

Ein-Tim commented 2 years ago

Version 2.23 has been released. Closing this issue as implemented.