I really like the idea of this project, hence I started looking a little bit around and stumbled across the Dockerfile where some lines caught my attention.
@Question
First of all, what is the purpose of the Dockerfile? Should it be used as development environment? Or should it only execute the crawler? The documentation does not really provide any clues on this which makes it really hard to understand what is does (even though it is not that huge).
Improvements
Depending on the actual purpose, I would strongly recommend to kick out everything not needed, e.g.:
Why do we need sudo and in particular, why do you allow the user python to use sudo without a password? In other words, why do you need the user python to be root?
Do we really need git?
What's the matter with the build and source volumes? This looks a little bit strange for a python-based project.
I could also provide a pull-request, as soon as you provide some more details on this.
Hello,
I really like the idea of this project, hence I started looking a little bit around and stumbled across the
Dockerfile
where some lines caught my attention.@Question First of all, what is the purpose of the Dockerfile? Should it be used as development environment? Or should it only execute the crawler? The documentation does not really provide any clues on this which makes it really hard to understand what is does (even though it is not that huge).
Improvements Depending on the actual purpose, I would strongly recommend to kick out everything not needed, e.g.:
sudo
and in particular, why do you allow the user python to usesudo
without a password? In other words, why do you need the user python to be root?git
?build
andsource
volumes? This looks a little bit strange for a python-based project.I could also provide a pull-request, as soon as you provide some more details on this.