corona-zahlen-landkreis / corona_landkreis_fallzahlen_scraping

Scraping Germany's local districts websites for newer corona-case-numbers!
GNU General Public License v3.0
17 stars 9 forks source link

Purpose of the Dockerfile and improvments #62

Open dasmur opened 4 years ago

dasmur commented 4 years ago

Hello,

I really like the idea of this project, hence I started looking a little bit around and stumbled across the Dockerfile where some lines caught my attention.

@Question First of all, what is the purpose of the Dockerfile? Should it be used as development environment? Or should it only execute the crawler? The documentation does not really provide any clues on this which makes it really hard to understand what is does (even though it is not that huge).

Improvements Depending on the actual purpose, I would strongly recommend to kick out everything not needed, e.g.:

I could also provide a pull-request, as soon as you provide some more details on this.

dadosch commented 4 years ago

Those are very valid improvements :)

I don't know docker very well, so maybe @debugger-zz can help?

dasmur commented 4 years ago

I put all my suggestions into a commit and created a pull request. I would be happy for any comments on this.