coronabytes / dotnet-arangodb

.NET Driver for ArangoDB
Apache License 2.0
66 stars 18 forks source link

Return old good fixed query formatter #15

Closed ASolomatin closed 3 years ago

ASolomatin commented 3 years ago

Hi.

Regular expressions is not a good idea here. This will hit performance and will not help with complex queries built from the parts. Building query from parts is important because queries some times are very complex and building from different parts of application even from different libraries.

Initial bug was only in recursive formatting all IFormattable properties, now recursive formatting will be applied only to FormattableString and classes that implements special IArangoFormattable interface.

Instead of reverting, you always can open issue on me, i'm online almost every day and very interested in this connector, because in our project it is almost in production.