search

coronalabs / corona

Solar2D Game Engine main repository (ex Corona SDK)
https://solar2d.com/
MIT License
2.54k stars 273 forks source link

Android: keep resource as is #609

Closed clang-clang-clang closed 1 year ago

clang-clang-clang commented 1 year ago

The option setting 'android.enableResourceOptimizations=false' is deprecated. The current default is 'true'. It will be removed in version 8.0 of the Android Gradle plugin.

^ Although the Android Gradle plugin will complain, but afaik Solar2D need to keep the widget resource as-is before found out more practical solution.

clang-clang-clang commented 1 year ago

Added memo #610

Shchvova commented 1 year ago

Oh. Does something breaks because of this flag is true? Btw, you can edit your issues/PRs ;)

clang-clang-clang commented 1 year ago

Refer: commit ad9bf162e2db195a5d8d4682336009b20db1d072 and commit f12fb5748dc1fe3f98610101be4647be4f3eabf8

Without the option, the default value of "true" is used, which results in the resource filenames being shrink and obfuscated, resulting in the widget resource not being found.

Set the option to false is temporary solution (this PR), may find another solution later (#610 as memo) :D

clang-clang-clang commented 1 year ago

follow up on #611

Shchvova commented 1 year ago

Haha :) I am the one who put it there in the first place.