coronalabs / corona

Solar2D Game Engine main repository (ex Corona SDK)
https://solar2d.com/
MIT License
2.54k stars 273 forks source link

[Apple]: runtime bug, network EXC_BAD_ACCESS #634

Closed clang-clang-clang closed 1 year ago

clang-clang-clang commented 1 year ago

Describe the bug In plugin/network/apple, NetworkRequestState's fRequestURL EXC_BAD_ACCESS in pushToLuaState.

To Reproduce

Possible Solution

plugin/network/apple/AppleNetworkSupport.mm
    fPhase = @"began";
    fStatus = -1;
-   fRequestURL = url;
+   fRequestURL = [url copy];
    fResponseHeaders = nil;
    fResponseType = @"text";

iOS will take effect, but macOS need run build.sh first then copy network.dylib from build-core.

About License

Are the submodule-plugins-network and submodule-plugins-build-core and all the submodules follow up this main repo's MIT license? @Shchvova May I ask to setup a proper LICENSE on those repos?

clang-clang-clang commented 1 year ago

Related to https://github.com/coronalabs/corona/issues/632.

clang-clang-clang commented 1 year ago

Possibly relevant Xcode 15 Release Notes:

Apple Clang Compiler

Resolved Issues

clang-clang-clang commented 1 year ago

Fixed in 3699.