coronanet / rn-coronanet

React native interface of the Corona Network
12 stars 4 forks source link

Connect profile API #10

Closed 0mkara closed 4 years ago

0mkara commented 4 years ago
karalabe commented 4 years ago

Could you please attach a few screenshots? Would be easier to discuss general directions if I could glimps without having to build and deploy everything.

0mkara commented 4 years ago
  1. Login simply means if you already have created a profile continue with that profile data.
  2. Delete that profile data with the delete button Screenshot_1585413448
0mkara commented 4 years ago
  1. If no profile already exists show register button on welcome screen
  2. Register button takes us to Signup page
  3. Create user button creates a profile and PUT user data in it Screenshot_1585413497

Hope we are following the API till here.

karalabe commented 4 years ago

I've been thinking about this PR for a bit, but all in all I'm a bit wary of the general methodology. The original UI I made was a PoC to have an idea of what's needed, but since then those were evolved a bit in https://github.com/coronanet/rn-coronanet/issues/1. Would be nice to take those discussions into consideration too, otherwise we'll have two diverging idea sets.

Re this PR a few issues I mentioned before in https://github.com/coronanet/rn-coronanet/issues/11#issuecomment-605466656:

A general issue that I'm afraid of with this PR is that it kind of hacks in network requests, handling and whatnot all together. Yes, it's good for a fast PoC, but I won't be able to maintain such a code base.

I kind of feel that the approach @daodesigner is taking in https://github.com/coronanet/rn-coronanet/pull/12 is a bit more elegant, as the network requests are completely separate from rendering. I'm also more of a building from the ground up person.

The correct approach I think would be to define the screens that are needed and then go about implementing them. Since @daodesigner started defining them, it might make sense to collaborate (or build the bases for that) than to try and make the current UI work, which will be dropped either way.

0mkara commented 4 years ago

I just checked PR #12. I completely agree with your decision. I would like @daodesigner to continue the design implementations. I will keep an eye on further development there. Let's continue the discussion on PR #12 and let me see what I can do there. :+1: