coronasafe / care_fe

Care is a Digital Public Good enabling TeleICU & Decentralised Administration of Healthcare Capacity across States.
https://care.ohc.network
MIT License
186 stars 348 forks source link

Update filter button behaviour when filters are applied #8045

Open Dev-Harwani opened 1 week ago

Dev-Harwani commented 1 week ago

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

vercel[bot] commented 1 week ago

@Dev-Harwani is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

netlify[bot] commented 1 week ago

Deploy Preview for care-egov-staging ready!

Name Link
Latest commit c264b09b4f6f8487503af09d3c89ef230a7eed5f
Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66767c1e100aed0009b233fc
Deploy Preview https://deploy-preview-8045--care-egov-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nihal467 commented 1 week ago

@Dev-Harwani image

Since we changed the text, you forgot to update the logic for the page. In your PR, we can see monitors without patients when the checkbox is unticked. Please modify the logic so that when the checkbox for "show monitors without patients" is unchecked, no monitors without patients should be shown on the CNS page.

note: you can use critical care facility cns page for testing this scenario in deploy preview

Dev-Harwani commented 1 week ago

Hi @nihal467! I have updated the logic as well. Please verify. Thanks Screenshot 2024-06-22 125606 Screenshot 2024-06-22 125625

github-actions[bot] commented 1 day ago

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.