coroo / nova-chartjs

A Simple Dashboard Chart in Laravel Nova using Chart JS. Starting create your own dashboard with Chart JS Integration can save your time and help you maintain consistency across standard elements such as Bar, Stacked, Line, Area, Doughnut and Pie Chart.
https://coroo.github.io/nova-chartjs
MIT License
215 stars 71 forks source link

[BUG] - No padding for Laravel Nova Charts cards #140

Closed samrcruz closed 1 year ago

samrcruz commented 2 years ago

Describe the bug there is no top padding on laravel nova 4

To Reproduce Steps to reproduce the behavior: add a simple larave nova chart example

Expected behavior padding on the chartjs cards should be the same as normal laravel nova 4 cards

Screenshots image

Dependencies Version (please complete the following information):

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

WillyReyno commented 2 years ago

Having the same bug here, is there any release planned to fix it?

Oskar-Mikael commented 1 year ago

Issue still persists. The Card div's simply seem to be missing their padding classes

coroo commented 1 year ago

By default, the layout using this configuration: padding: { left: 20, right: 20, top: 0, bottom: 10 }

If you need to change the style padding, you can have it within this documentation: https://coroo.github.io/nova-chartjs/#/?id=layout

CrystallDEV commented 1 year ago

By default, the layout using this configuration: padding: { left: 20, right: 20, top: 0, bottom: 10 }

If you need to change the style padding, you can have it within this documentation: https://coroo.github.io/nova-chartjs/#/?id=layout

This does not solve the underlying issue. As mentioned before: The card itself is missing the padding classes, which are also used by all the base nova metrics. Adding a padding to the chart itself does not fix the missing padding (for example for the title).

benedict-w commented 1 year ago

I also see the same issue, it's not the padding in the chart options, but the padding classes on the card that are missing.

Anyone know a workaround?

fruitl00p commented 1 year ago

We're seeing the same thing: the title is styled wrong (h4 vs h3 amoungst other things) image