Closed keisku closed 7 months ago
Thanks, @keisku, for the detailed report. The agent uses a rate limiter for logging, which may create the impression of it hanging. Other than the log, what other problems do you see with the agent?
@def Thanks! I overlooked the rate limit.
Other than the log, what other problems do you see with the agent?
curl failed for these endpoints and I didn't see these logs. Then I thought some operation hanged.
But the actual problem was that I didn't set --port
for docker run
.
So, my issue has been solved 👍
Btw, why do we need the rate limit?
We added the rate limit to prevent situations, such as those described in #17
@def
Can we make the rate limit configurable with flags?
@keisku, sure, I merged your PR
Description
This function hangs. Especially, dest, err := os.Readlink(path.Join(fdDir, entry.Name()))
https://github.com/coroot/coroot-node-agent/blob/8e1fa825ad97ce88d587e8991cd8357c19f90dd4/proc/fd.go#L17-L40
Reproduction
I've inserted additional trace logs to precisely identify the code segment responsible for this issue. Also followed this doc.
See the result of
git diff
.trace-log.patch
Logs
See the attachment,
docker logs coroot-node-agent-dev
result.docker.log