search

coroot / coroot-node-agent

A Prometheus exporter based on eBPF that gathers comprehensive container metrics
https://coroot.com/docs/metrics/node-agent
Apache License 2.0
294 stars 54 forks source link

Sorted the order of file paths #85

Closed Broot-bite closed 1 month ago

Broot-bite commented 1 month ago

Good afternoon, Coroot team!

I kindly ask for your attention to my pull request. The changes made are due to some cloud providers creating virtual machines with the same product_uuid. This leads to a situation in the Coroot web interface where a single node represents multiple virtual machines. The change in the order of paths will resolve this issue and ensure correct representation of virtual machines in the interface.

Thank you in advance for considering this.

Broot-bite commented 1 month ago

My colleague has also written to the issuer about this matter. https://github.com/coroot/coroot/issues/145#issuecomment-2099783720

def commented 1 month ago

LGTM. I've also verified that the Kubernetes machine_id is obtained in the same order

@Broot-bite thanks for you contribution!