Allow to change prometheus scrape annotations

coroot / helm-charts

Coroot Helm charts

Apache License 2.0

18 stars 20 forks source link

Allow to change prometheus scrape annotations #21

Open grzesuav opened 4 months ago

grzesuav commented 4 months ago

In our setup we have different prometheuses, one special for coroot and one for the whole cluster.

I have coroot promehteus targeting specific coroot pods - node agents and ksm - however due to presence of prometheus.io/scrape: 'true' it is also scraped by global fleet, which is undesired.

Currently this annotation is hardcoded, my proposal is to move it to values.podAnnotations - it still be a default, however people coud change it if needed

grzesuav commented 2 months ago

@def implemented this in https://github.com/coroot/helm-charts/pull/28 in backward compatible manner