search

coroot / helm-charts

Coroot Helm charts
Apache License 2.0
13 stars 15 forks source link

.Values.prometheus.server.service is referenced, but not defined in values.yaml #5

Closed CrazyByDefault closed 8 months ago

CrazyByDefault commented 1 year ago

On attempting to use existingPrometheus set via a custom values.yaml, helm throws the following error during install - 

Error: template: coroot/templates/deployment.yaml:38:134: executing "coroot/templates/deployment.yaml" at <.Values.prometheus.server.service.enabled>: nil pointer evaluating interface {}.enabled

The reference is being made from here - https://github.com/coroot/helm-charts/blob/8d87d73d4f2e5d708bed26187f112c66646e47d8/charts/coroot/templates/deployment.yaml#L38

However, even the default values.yaml does not contain a service section inside prometheus.server - https://github.com/coroot/helm-charts/blob/8d87d73d4f2e5d708bed26187f112c66646e47d8/charts/coroot/values.yaml#L74

Either a service block needs to be added, or the variable should not be checked during templating.

apetruhin commented 1 year ago

@CrazyByDefault, thank you for the report. Please update to the latest chart version.