search

corot / world_canvas

ROS framework for storing and accessing semantic information about the world, with an initial emphasis on needs and use cases for mobile robots.
10 stars 19 forks source link

separating rviz plugin to different repo? #24

Closed jihoonl closed 9 years ago

jihoonl commented 9 years ago

I think it would be better if world_canvas_server is independent from rviz plugin. How do you think?

stonier commented 9 years ago

:+1:

corot commented 9 years ago

:-1:

corot commented 9 years ago

ㅋㅋㅋ

ㅇㅇ, 할거야 as soon as I have a first beta

jihoonl commented 9 years ago

네! Just letting you know that raised this issue because I couldn't compile the code in my pc..

See issue #26

corot commented 9 years ago

I'm a bit uneasy with exploding the number of repos.... mostly because we tend to have 1 repo - package! What makes all a bit "noisier" and less comfortable for releasing (duplicates work) and git management (imho).

In this particular case, I think don't make a lot of sense to split repo, as the editor is useless without the server, and the server is of few use without the tool that creates the content it server!

Messages and client libraries ok, as clients will hardly need the server stuff, by definition.

jihoonl commented 9 years ago

Hm.. IMO, having four repository(Server, Client, Msg, and Visualization) with meaning sounds reasonable.

rviz_plugin would bring many visualization dependency which would not need for server. I imagine the world canvas server runs in the backbone system(which wouldn't have monitor) and serves the system as database. And users control the server data through client library.

Um... if you are concerned about explosion of number of repositories, how about moving the rviz and rqt stuffs into world_canvas_libs repository? Since client libraries are directly used in the rviz_plugin, I think it would be another way.

corot commented 9 years ago

OK, I see the point. Maybe you are right. Let's talk it in our next skype meeting.

But not on world_canvas_libs repository, as this must be as lightweight as possible cause contains client libraries that can be installed by many end users

corot commented 9 years ago

:+1: for a new repo named world_canvas_tools