search

corot / world_canvas

ROS framework for storing and accessing semantic information about the world, with an initial emphasis on needs and use cases for mobile robots.
10 stars 19 forks source link

annotations server? world canvas server? #25

Closed jihoonl closed 9 years ago

jihoonl commented 9 years ago

I have noticed that the modules are called as Annotations Server, and Annotations Collection. But it also saves maps and the other message formats too.

Wouldn't it be better to call them as World Canvas Server and World Canvas Client? I feel Annotations Server makes its purpose weaker.

corot commented 9 years ago

Annotations Collection makes sense as it is cause it's mostly that: an list of annotations retrieved from the server according to some filter criteria.

For the server.... well, that file in particular only server annotations, what make sense. But... well, I could be misguiding at some point. I let the discussion opened. @stonier, do you have any preference?

stonier commented 9 years ago

Correct me if I'm wrong, but I believe the annotations are the mechanism that makes it all work and these are the things that are being handled by the user here.

Is there potential for specific instances of things like DoorServer and DoorClient that could be wrappers around this functionality? If there is likely to be more than one way of interacting with the world canvas server...annotations seems alright to me. If there is only one way, then world canvas server would seem right.

corot commented 9 years ago

Since 5d48a2c9f1fea946ae50f259d86bc1999a8c98a4 we call the server with a world_canvas_server script, while the package that handles the annotations is still named annotations_server.py. So all clear now, I think.

jihoonl commented 9 years ago

Sweet thanks :)