pep8 rule for python module?

corot / world_canvas

ROS framework for storing and accessing semantic information about the world, with an initial emphasis on needs and use cases for mobile robots.

10 stars 19 forks source link

pep8 rule for python module? #30

Closed jihoonl closed 9 years ago

jihoonl commented 9 years ago

It is a suggestion. Python code used in rocon project follows pep8(python styling guideline) which is recommended by ROS styleguide.

How about following this? It is a bit different from cpp style. Would it be good to keep the function name same as cpp library? How do you think @stonier?

FYI,
ROS Python style guide : http://wiki.ros.org/PyStyleGuide Pep8 : http://legacy.python.org/dev/peps/pep-0008/

corot commented 9 years ago

Yep, I tried to maintain similar APIs in both C++ and Py. But in general I'm in favor of coding standards, so... I'm not against using Pep8. But I think most of the code is conformant, apart form the methods names

corot commented 9 years ago

OK, let's do Pep8.

Btw, also rearrange methods headers, as I put the description below the parameters and return values!

corot commented 9 years ago

I just renamed methods, but I think most of the code was already conformant. Please re-open if other Pep8 are not respected.