corpnewt / SSDTTime

SSDT/DSDT hotpatch attempts.
MIT License
1.09k stars 180 forks source link

Return value for fake EC #56

Open Drovosek01 opened 2 years ago

Drovosek01 commented 2 years ago

Using the SSDTTime script, I extracted DSDT on Windows and generated FakeEC tables for my Chinese x79 motherboard

Some time later, while studying the instructions, I looked in detail at the source code of ST EC Desktop, which lies in the OpenCore repository https://github.com/dortania/Getting-Started-With-ACPI/blob/master/extra-files/decompiled/SSDT-EC-DESKTOP.dsl and I saw that the returned values in the file from the repository and in the generated file are oppositely different

In the dsl file generated by SSDTTIme, here is a condition with return values:

image

If (_OSI ("Darwin"))
{
Return (0x0F)
}
Else
{
Return (Zero)
}

And in the dsl file from the OpenCore repository , this is:

https://github.com/dortania/Getting-Started-With-ACPI/blob/master/extra-files/decompiled/SSDT-EC-DESKTOP.dsl#L560

If (_OSI ("Darwin"))
{
Return (Zero)
}
Else
{
Return (0x0F)
}

Actual questions:

  1. Is there a difference between such return values?
  2. Which option is correct in this case?